4001 - Datatable use Datagrid #4104
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 4001: Initial DataGrid POC Co-authored-by: Alejandro Guzman <[email protected]> * 4001: update grid first col size Co-authored-by: Alejandro Guzman <[email protected]> * 4001: add gridColumn + gridRow Co-authored-by: Alejandro Guzman <[email protected]> --------- Co-authored-by: Alejandro Guzman <[email protected]>
* 4001 - Add initial header styles * 4001 - Split styles
44 tasks
* 4001 - Add data-tooltip-html prop in DataCell * 4001 - Separate old useClassName & add table-grid__data-cell class * 4001 - Add calculated cell styles * 4001 - Update useClassName
* 4001 - Clone TableHead as GridHead using DataCells * 4001 - Add getODPHeader util * 4001 - Extract cell rendering logic to custom hook * 4001 - Update styles * 4001 - Update OdpHeaderCell * 4001 - Fix ReviewSummaryIndicator placement * 4001 - Update odp header class name * 4001 - Add GridHeadCell component * 4001 - Remove cycle return * 4001 - Move getODPHeader * 4001 - Add GridHeadCellProps type * 4001 - Use classNames * 4001 - Update getODPHeader import path
* 4001 - Remove Multiselect from Table Grid * 4001 - Add initial Grid Table layout fixes * 4001 - Add FRA 2025/2020 layout fixes * 4001 - Fix undefined spans * 4001 - Add panEuropean 2025/2020 layout fixes
…#4134) * 4001 - Add missing category cell style * 4001 - Display notice messages * 4001 - Add missing key prop * 4001 - Fix cell placeholder style * 4001 - Sort props * 4001 - Rename useTableData to useParsedTable * 4001 - Remove text-aligns & add rtl * 4001 - Rename parsedTable to table * 4001 - Move parseTable file * 4001 - Remove rows concat
* 4001 - Fix layouts when review comments are enabled * 4001 - Add highlight props * 4001 - Add table actions * 4001 - Add DataRow highlightRange prop * 4001 - Add highlightRange to grid table * 4001 - Update highlightRange calculation * 4001 - Add firstHighlightCol & lastHighlightCol * 4001 - Fix DataRow first & last col bug
* 4001 - Remove GridHead component * 4001 - Remove GridRow component * 4001 - Fix cells padding * 4001 - Fix cell editable prop * 4001 - Update text inputs * 4001 - Delete VerticallyGrowingTextField component * 4001 - Delete Old TextInput component * 4001 - Fix Select container style * 4001 - Rollback changes to InviteUserForm
* 4001 - Add InputNumber & use it for InputPercent * 4001 - Use InputNumber instead of ThousandSeparated inputs * 4001 - Sync input local value after paste * 4001 - Simplify cell Number component * 4001 - Remove isInteger, shouldRound, & thousandSeparated props * 4001 - Add className, onBlur & onFocus to InputText * 4001 - Use InputText and remove localValue
* 4001 - Add CreatableSelect and input props * 4001 - Add input event props * 4001 - Fix Taxon code not being persisted * 4001 - Update Taxon component * 4001 - Add createOptionPosition & remove onPaste from Select * 4001 - Add current node to options & save onBlur * 4001 - Add migration taxon codes fix * 4001 - Add _fixColumnNames function * 4001 - Compile together column fixes * 4001 - Delete Autocomplete component * 4001 - Delete downshift dependency * 4001 - Remove Taxon disabled classname * 4001 - Use Objects.isEmpty in useOnChange * 4001 - Handle paste in Select itself * 4001 - Use common.add and remove common.addValue
) * 4001 - Add Table props->style * 4001 - Add FRA 2025 gridTemplateColumns where necessary * 4001 - Remove all col styles related to width * 4001 - Target only FRA for Taxon codes fix * 4001 - Add FRA 2020 gridTemplateColumns * 4001 - Add gridTemplateColumns to Table component * 4001 - Add useGridTemplateColumns hook
…pean (#4189) * 4001 - Add panEuropean 2020 gridTemplateColumns * 4001 - Add panEuropean 2025 gridTemplateColumns * 4001 - Pass custom classname to InputText disabled div
…ader row & Minor fixes (#4190) * 4001 - Fix Growing Stock Composition 2025 header rows * 4001 - Fix table_1_4b_2020 labels * 4001 - Remove unnecessary section -> table styles * 4001 - Make RowNoticeMessage span entire row
minotogna
reviewed
Dec 30, 2024
src/test/migrations/steps/20241114204645-step-fix-datatable-grid-layouts-and-taxon-codes.ts
Outdated
Show resolved
Hide resolved
minotogna
reviewed
Dec 30, 2024
src/test/migrations/steps/20241114204645-step-fix-datatable-grid-layouts-and-taxon-codes.ts
Outdated
Show resolved
Hide resolved
* 4001 - Use filename logic from ButtonTableExport in ButtonGridExport * 4001 - Handle cells that are calculated and input * 4001 - Handle spanning cells in DataGrid export * 4001 - Fix table 7c NWFP category export * 4001 - Fix odp year with status not being exported * 4001 - Fix table 3a duplicated text bug * 4001 - Fix growingStockComposition2025 export layout * 4001 - Update useClassName hook * 4001 - Use route params in OdpHeaderCell * 4001 - Highlight only non text input calculated cells
…lly center input disabled & Cache fix (#4193) * 4001 - Hide Taxon DropdownIndicator * 4001 - Vertically center disabled input cells * 4001 - Generate data cache only for affected tables --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* 4001 - Copy values from grid * 4001 - Move and refactor Copy logic to useCopyValues hook * 4001 - Minor rtl fix for disabled input number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4001
Resolves #1945
Remove Select indicator in Taxon cell
Update
ButtonCopyValuescomponent to use the DataGrid ref instead of the Table refCalculate borders based on col and row spans
Check that print works as before
Check download functionality
Fix column widths and add grid template columns to table
Fix table headers for Forest growing stock composition -> add all headers to one row instead of two
Update Taxon cell component and delete old dependencies -> Use Select instead of Autocomplete
Update Text cells -> Use InputText and TextArea
Update numeric cells -> Add InputNumber
Investigate
ColType.placeholderCreate new Cell styles (CellHeader and Cell)
Update colSpan/rowSpan to gridColGap / gridRowGap
Add row headers
RowData: add actions (review)
GridRow: add RowNoticeMessage
Fix src/client/pages/Section/DataTable/Table/GridRow/RowData/RowData.tsx
Fix src/client/pages/Section/DataTable/Table/GridRow/RowData/CellHeader/CellHeader.tsx
Move DataGrid (in Table.tsx) as parent of all elements
Update data grid style
go through DataTable and Table sass files
investigate usage of 'fra-table' css class name
investigate usage of 'fra-table__select-container' @minotogna see Remove ColType multiselect. Refactor Multiselect->Select isMulti #4106
Investigate src/client/pages/Section/DataTable/Table/GridRow/RowData/Cell/Cell.scss
Investigate and remove? all fra-table prefixed css classes ?