Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version conformance (#163) #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomkralidis
Copy link

Addresses #162.

Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (Automated numbering of section swould be good too ;-)

@chris-little
Copy link
Contributor

@jonblower Are you happy to merge this PR163 to address Issue #162 ?

@jonblower
Copy link
Contributor

@chris-little @tomkralidis I have no objection in principle to the idea. But before we do anything, I think we'll need to sort out this repo to create a tag for the final version 1.0.0, and establish that future PRs will be targeting version 1.1 (and maintain a changelog). Also we'd need to update the schema.

Would this be a compulsory property from version 1.1 onwards? Maybe it should be optional to maintain backward compatibility? I assume it would apply to all CoverageJSON documents?

@tomkralidis
Copy link
Author

My vote would be compulsory moving forward only, unless there are other ways to do version detection?

@chris-little
Copy link
Contributor

I am happy for Mandatory for future versions, e.g. V1.1. And absence implies V1.0. @tomkralidis

@jonblower Do you think that this is not a completely backward compatible change? Isn't an unidentified JSON object or attribute or property ignored? If so, could we make this V1.0.1. I agree tagging is needed.

@chris-little chris-little added V1.1 Non-breaking change for Version 1.1 Priority 1 Highly desirable labels Jul 11, 2024
@chris-little chris-little changed the title add version conformance (#162) add version conformance (#163) Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 1 Highly desirable V1.1 Non-breaking change for Version 1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants