Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public comment working branch #59

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Public comment working branch #59

merged 4 commits into from
Nov 28, 2023

Conversation

ronaldtse
Copy link
Collaborator

No description provided.

cmheazel and others added 2 commits November 16, 2023 12:45
@cmheazel
Updates for PDF
b6dc3d7 
These updates were made as part of an effort to generate a "clean" PDF rendering.
@ronaldtse
chore: use auto-fetch for ISO and OGC bibliographic entries
1c97e11
chris-little
chris-little requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldtse @cmheazel Should there be marign and wieght key words in the html document instead of margin and weight? Several occurences of each, and I thought I had edited them out previously.

chris-little
chris-little reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldtse @cmheazel Once the wieght and marign issue sorted, happy to approve.

@chris-little
Copy link
Contributor

@ronaldtse @ghobona The wieght and marign issue looks like a Metanorma bug. What is the best way forward please?

@ronaldtse
Copy link
Collaborator Author

Sorry @chris-little , those are not meant to exist. Typically in a Metanorma document there is no need to manually set any margin or width. I thought this PR removed them, but if not I’ll update it. I wasn’t the one who added them.

@ronaldtse
Copy link
Collaborator Author

@chris-little I don't see

@ronaldtse @ghobona The wieght and marign issue looks like a Metanorma bug. What is the best way forward please?

@chris-little I don't see this issue in the generated HTML content which you can download here from the latest build:

As Metanorma best practice we encourage users not to check-in their generated artifacts into version control (Git) but manage them using an alternative process like GitHub Releases.

@ronaldtse
Copy link
Collaborator Author

i.e. I would prefer removing these files from version control since they are generated artifacts:

23-049.doc
23-049.html
23-049.pdf
23-049.presentation.xml

chris-little
chris-little approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Sensible!

@chris-little chris-little merged commit 53d921d into master Nov 28, 2023
2 checks passed
@chris-little chris-little deleted the Public-Comment-Working-Branch branch November 28, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmheazel cmheazel cmheazel approved these changes

@chris-little chris-little chris-little approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronaldtse @chris-little @cmheazel