Changes for v1.2 #577

m-burgoyne · 2024-09-16T09:11:06Z

Add support for multi location requests
Add support for a limit query parameter
Add an annex for recommended aggregation method descriptions for measurementType
Updates the reference to the CoverageJSON community standard
Add paragraph to specify that the OpenAPI documentation served by the server as the definitive definition of the query parameters that the EDR server supports
Fix the time response requirement definition
Fix duplicate operationids in OpenAPI examples
Add support for requesting specific resolutions in the Cube query
Fix the measurementType examples
Change Annex A and Annex B to be normative
Add support to the Z query parameter for open ranges
Add missing Custom dimension definitions
Correct error in collection bbox definition

Add support for passing multiple location ids in a single locations request

chris-little · 2024-09-19T14:14:42Z

@m-burgoyne I suggest we need a more detailed History section, like Features.

chris-little

Let's hope the Metanorma changes work out OK.

chris-little · 2024-10-02T14:38:27Z

@tomkralidis @m-burgoyne The Generate OpenAPI Bundle workflow needs updating for a more current version of Swagger.

tomkralidis · 2024-10-02T15:47:15Z

@tomkralidis @m-burgoyne The Generate OpenAPI Bundle workflow needs updating for a more current version of Swagger.

Is there something broken in the current version?

chris-little · 2024-10-02T17:38:26Z

@tomkralidis https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/pull/577/checks but they may not matter. Mentions of node.js too. they are warnings rather than failures: warn deprecated @apidevtools/[email protected]:

tomkralidis · 2024-10-02T17:47:49Z

@tomkralidis https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/pull/577/checks but they may not matter. Mentions of node.js too. they are warnings rather than failures: warn deprecated @apidevtools/[email protected]:

Ah, ok. The node.js warnings are a function of the GitHub Actions. I've updated #581 to fix these warnings.

chris-little · 2024-10-03T14:18:50Z

EDR API SWG 122 2024-10-03 agreed to merge when last fixes tweaked (Metanorma problems)

chris-little

Phew! Well done @m-burgoyne

dblodgett-usgs · 2024-10-17T02:58:52Z

core/standard/sections/annex_history.adoc

@@ -25,4 +25,5 @@
 |2022-05-12 |Master branch|Mark Burgoyne | all | Add missing requirements and tests for data_queries metadata
 |2022-06-01 |1.0.1|G.Hobona | all | Final OGC Staff review
 |2023-06-30 |1.1|G.Hobona | all | Final OGC Staff review
+|2024-09-19 |1.2|Mark Burgoyne| all | Changes for v1.2 (link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/321[#321], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/398[#398], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/414[#414], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/455[#455], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/479[#479] link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/527[#527], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/529[#529], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/560[#560], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/565[#565])


Is this how we want to do history?

dblodgett-usgs · 2024-10-17T03:01:30Z

core/standard/sections/clause_3_references.adoc

+* [[[RFC2616,RFC 2616]]] Fielding, R., Gettys, J., Mogul, J., Frystyk, H., Masinter, L., Leach, P., Berners-Lee, T.: IETF RFC 2616, HTTP/1.1, https://tools.ietf.org/rfc/rfc2616.txt[https://tools.ietf.org/rfc/rfc2616.txt]
+* [[[RFC2818,RFC 2818]]] Rescorla, E.: IETF RFC 2818, HTTP Over TLS, https://tools.ietf.org/rfc/rfc2818.txt[https://tools.ietf.org/rfc/rfc2818.txt]
+* [[[RFC3339,RFC 3339]]] Klyne, G., Newman, C.: IETF RFC 3339, Date and Time on the Internet: Timestamps, https://tools.ietf.org/rfc/rfc3339.txt[https://tools.ietf.org/rfc/rfc3339.txt]
+* [[[RFC3896,RFC 3896]]] Berners-Lee, T., Fielding, R., Masinter, L: IETF RFC 3896, Uniform Resource Identifier (URI): Generic Syntax, https://tools.ietf.org/rfc/rfc3896.txt[https://tools.ietf.org/rfc/rfc3896.txt]


This should be 3986 -- don't ask my how I know.

dblodgett-usgs

Generally looks great. The "limit" addition is good. May be worth fixing a couple very minor things I noted.

chris-little · 2024-10-31T14:10:22Z

Agreed to merge at OGC EDR API SWG 2024-10-31 #123

lukas-phaf · 2024-12-16T08:33:36Z

I noticed that the rendering of the (two-column) table in Annex D for measurementType values has a problem, it renders as a 4 column table:
https://docs.ogc.org/DRAFTS/19-086r7.html#measurementType_methods_desc

m-burgoyne added 14 commits September 12, 2024 13:16

Add support for multi location requests

985c2b7

Add support for passing multiple location ids in a single locations request

Add support for optional limit parameter

08212da

Add an annex recommending aggregation methods for measurementType

e44d0eb

Add link to limit definition requirement

591fd65

Update reference to CoverageJSON Community Standard

44fdddd

Add query parameter definition message

780f18f

Fix time response requirement

d7741fe

Replace duplicate operationIds

449ec57

Add support for requesting specific resolution in /cube endpoint

f6a96d3

Clarification for locations endpoint

11ca2a4

Make data_query query_type attribute optional

51f9c49

Fix measurementType examples

4e82424

Change Annex A and B to be Normative

40243af

Include support for Z query parameter open ranges

78a16f1

This was referenced Sep 16, 2024

Add support for requesting specific resolution in cube endpoint #473

Closed

Other updates for v1.2 #472

Closed

Add support for multiple location requests #471

Closed

m-burgoyne requested review from tomkralidis, dblodgett-usgs, chris-little, solson-nws, ShaneMill1 and iandruska-ibl September 16, 2024 09:13

m-burgoyne added the API EDR V1.2 Non-breaking change for Version 1.2 label Sep 16, 2024

This was linked to issues Sep 16, 2024

Declarations of normative and informative sections need fixing in OGC API - EDR v1.2 #565

Closed

Clarification Needed for /locations Endpoint in OGC API - EDR Specification #568

Closed

tomkralidis approved these changes Sep 16, 2024

View reviewed changes

m-burgoyne added 2 commits October 1, 2024 09:39

Update release history

257ef3f

Remove duplicate link

65d4398

chris-little approved these changes Oct 2, 2024

View reviewed changes

Fix errors identified by Metanorma build

edadcd0

m-burgoyne requested review from tomkralidis and chris-little October 14, 2024 08:34

Add missing custom dimension information

b0e6c01

This was referenced Oct 15, 2024

C 5 Extent object is missing custom dimension in documentation #583

Closed

Format of bbox in spatial extent object #582

Closed

chris-little approved these changes Oct 15, 2024

View reviewed changes

dblodgett-usgs reviewed Oct 17, 2024

View reviewed changes

dblodgett-usgs approved these changes Oct 17, 2024

View reviewed changes

Fix reference to URI RFC

498adc9

chris-little approved these changes Oct 23, 2024

View reviewed changes

chris-little merged commit af85c84 into master Oct 31, 2024
1 check passed

chris-little deleted the changes-for-v1.2 branch October 31, 2024 14:10

chris-little mentioned this pull request Oct 31, 2024

Allow collections to specify optional query parameters as mandatory. #446

Closed

mo-lukecarr mentioned this pull request Dec 16, 2024

Replace period with duration in MeasurementType KNMI/edr-pydantic#15

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes for v1.2 #577

Changes for v1.2 #577

m-burgoyne commented Sep 16, 2024 •

edited

Loading

chris-little commented Sep 19, 2024

chris-little left a comment

chris-little commented Oct 2, 2024

tomkralidis commented Oct 2, 2024

chris-little commented Oct 2, 2024 •

edited

Loading

tomkralidis commented Oct 2, 2024

chris-little commented Oct 3, 2024

chris-little left a comment

dblodgett-usgs Oct 17, 2024

dblodgett-usgs Oct 17, 2024

dblodgett-usgs left a comment

chris-little commented Oct 31, 2024

lukas-phaf commented Dec 16, 2024

Changes for v1.2 #577

Changes for v1.2 #577

Conversation

m-burgoyne commented Sep 16, 2024 • edited Loading

chris-little commented Sep 19, 2024

chris-little left a comment

Choose a reason for hiding this comment

chris-little commented Oct 2, 2024

tomkralidis commented Oct 2, 2024

chris-little commented Oct 2, 2024 • edited Loading

tomkralidis commented Oct 2, 2024

chris-little commented Oct 3, 2024

chris-little left a comment

Choose a reason for hiding this comment

dblodgett-usgs Oct 17, 2024

Choose a reason for hiding this comment

dblodgett-usgs Oct 17, 2024

Choose a reason for hiding this comment

dblodgett-usgs left a comment

Choose a reason for hiding this comment

chris-little commented Oct 31, 2024

lukas-phaf commented Dec 16, 2024

m-burgoyne commented Sep 16, 2024 •

edited

Loading

chris-little commented Oct 2, 2024 •

edited

Loading