Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile

[gounux]

This PR will :

• Create a simple_bumblebees_wrong_localized.qgs QGIS project file with 3 layers :
  • 1 (invalid) layer with a datasource with non existing filename
  • 1 (invalid) localized layer with a datasource with non existing filename
  • 1 (valid) localized layer with a datasource with existing filename (QFC should consider it as invalid because it is localized)
• Test that a PROCESS_PROJECTFILE type job parses the layer data correctly
• Test that a PACKAGE type job parses the layer data correctly

[duke-nyuki]

Task linked: QF-4081 Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile

[suricactus]

@gounux in case you did not use already, please install https://plugins.qgis.org/plugins/trackable_project_files/ to make the .qgs file git trackable.

[suricactus]

A few comments on the test.

[suricactus]

If you define:

    def assertLayerData(self, layer_data: dict, is_valid: bool, is_localized: bool, error_code: str):
        self.assertEquals(layer_data["is_valid"], is_valid)
        self.assertEquals(layer_data["is_localized"], is_localized)
        self.assertEquals(layer_data["error_code"], error_code)

You can simplify the code and improve readability to something like:

Suggested change

	self.assertFalse(invalid_localized_layer["is_valid"])
	self.assertTrue(invalid_localized_layer["is_localized"])
	self.assertEquals(
	invalid_localized_layer["error_code"], "localized_dataprovider"
	)
	self.assertLayerData(
	processfile_layers["invalid_localized_polygon_layer_id"],
	False,
	True,
	"localized_dataprovider",
	)

[gounux]

Thanks for the suggestion ! Indeed it makes things more simple.

I've actually been using parameters keywords when calling the function, for more readability, like this :

self.assertLayerData(
  processfile_layers["invalid_localized_polygon_layer_id"],
  is_valid=False,
  is_localized=True,
  error_code="localized_dataprovider",
)

What do you think ?