Fix getting the list of available teams per organization #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem comes from the fact that `teamname` is a runtime property of the `Team` class and not an actual database field. In addition we were using `Team.object.values()` which returns an `Iterable[dict]`, instead of `Iterable[Team]`. So even if it returned the right type, it would have been terribly slow, due to N+1 situation. This problem made the `/user/<username>/organization` return an error, therefore prevented QFieldSync from selecting the available organizations for the team.
gounux
approved these changes
Jan 7, 2025
| .select_related("team_organization") | ||
| .only("username", "team_organization__username") | ||
| ) | ||
|
|
There was a problem hiding this comment.
Quick question : do you consider this empty line as necessary ? (l195)
There was a problem hiding this comment.
Usually I keep keyword lines separated from the rest of the code, not super hard enforced, but IMO makes it slightly easier to find where the return is.
|
Sentry Issue: QFIELDCLOUD-2ME |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem comes from the fact that
teamnameis a runtime property of theTeamclass and not an actual database field. In addition we were usingTeam.object.values()which returns anIterable[dict], instead ofIterable[Team]. So even if it returned the right type, it would have been terribly slow, due to N+1 situation.This problem made the
/user/<username>/organizationreturn an error, therefore prevented QFieldSync from selecting the available organizations for the team.