chore: add s3 bucket url to config

opengovsg · Sep 20, 2023 · b718e23 · b718e23
1 parent 673895f
commit b718e23
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/src/app/config/config.ts b/src/app/config/config.ts
@@ -76,6 +76,7 @@ const s3BucketUrlVars = convict(s3BucketUrlSchema)
     attachmentBucketUrl: `${awsEndpoint}/${basicVars.awsConfig.attachmentS3Bucket}/`,
     virusScannerQuarantineS3BucketUrl: `${awsEndpoint}/${basicVars.awsConfig.virusScannerQuarantineS3Bucket}`,
     virusScannerCleanS3BucketUrl: `${awsEndpoint}/${basicVars.awsConfig.virusScannerCleanS3Bucket}`,
+    paymentProofS3BucketUrl: `${awsEndpoint}/${basicVars.awsConfig.paymentProofS3Bucket}`,
   })
   .validate({ allowed: 'strict' })
   .getProperties()

diff --git a/src/app/config/schema.ts b/src/app/config/schema.ts
@@ -485,5 +485,11 @@ export const loadS3BucketUrlSchema = ({
         validateS3BucketUrl(val, { isDev, hasTrailingSlash: false, region }),
       default: null,
     },
+    paymentProofS3BucketUrl: {
+      doc: 'Url of payment proof S3 bucket.',
+      format: (val) =>
+        validateS3BucketUrl(val, { isDev, hasTrailingSlash: false, region }),
+      default: null,
+    },
   }
 }
diff --git a/src/app/modules/payments/payments.service.ts b/src/app/modules/payments/payments.service.ts
@@ -183,6 +183,7 @@ export const confirmPaymentPendingSubmission = (
         paymentDate,
         receiptUrl,
         transactionFee,
+        hasS3ReceiptUrl: false,
       }
       return okAsync(payment)
     })

diff --git a/src/types/config.ts b/src/types/config.ts
@@ -125,6 +125,7 @@ export interface ICompulsoryVarsSchema {
     attachmentS3Bucket: string
     virusScannerQuarantineS3Bucket: string
     virusScannerCleanS3Bucket: string
+    paymentProofS3Bucket: string
   }
 }
 
@@ -199,5 +200,6 @@ export interface IBucketUrlSchema {
   staticAssetsBucketUrl: string
   virusScannerQuarantineS3BucketUrl: string
   virusScannerCleanS3BucketUrl: string
+  paymentProofS3BucketUrl: string
   endPoint: string
 }