fix: fix based on chromatic review

opengovsg · Jun 25, 2024 · b99448d · b99448d
1 parent 5efe3b3
commit b99448d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/__tests__/e2e/helpers/createForm.ts b/__tests__/e2e/helpers/createForm.ts
@@ -291,9 +291,7 @@ const addAuthSettings = async (
   await page.getByRole('tab', { name: 'Singpass' }).click()
 
   // Ensure that we are on the auth page
-  await expect(
-    page.getByRole('heading', { name: 'Enable Singpass authentication' }),
-  ).toBeVisible()
+  await expect(page.getByRole('heading', { name: 'Singpass' })).toBeVisible()
 
   await page
     .locator('label', {

diff --git a/frontend/src/features/admin-form/settings/SettingsAuthPage.tsx b/frontend/src/features/admin-form/settings/SettingsAuthPage.tsx
@@ -18,7 +18,7 @@ export const SettingsAuthPage = (): JSX.Element => {
 
   return (
     <>
-      <CategoryHeader>Enable Singpass authentication</CategoryHeader>
+      <CategoryHeader>Singpass</CategoryHeader>
       <AuthSettingsSection />
     </>
   )

diff --git a/...atures/admin-form/settings/components/AuthSettingsSection/AuthSettingsDescriptionText.tsx b/...atures/admin-form/settings/components/AuthSettingsSection/AuthSettingsDescriptionText.tsx
@@ -6,7 +6,7 @@ import Link from '~components/Link'
 export const AuthSettingsDescriptionText = () => {
   return (
     <Text textStyle="subhead-1" color="secondary.500" mb="2.5rem" mt="2.5rem">
-      Authenticate respondents by NRIC.{' '}
+      Authenticate respondents by NRIC/FIN.{' '}
       <Link
         textStyle="subhead-1"
         href={GUIDE_SPCP_ESRVCID}

diff --git a/...nd/src/features/admin-form/settings/components/AuthSettingsSection/FormNricMaskToggle.tsx b/...nd/src/features/admin-form/settings/components/AuthSettingsSection/FormNricMaskToggle.tsx
@@ -1,4 +1,4 @@
-import { useCallback, useMemo } from 'react'
+import { useCallback } from 'react'
 
 import { FormSettings } from '~shared/types/form'
 
@@ -31,8 +31,8 @@ export const FormNricMaskToggle = ({
       isDisabled={isDisabled}
       isLoading={!settings || mutateNricMask.isLoading}
       isChecked={isNricMaskEnabled}
-      label="Enable NRIC masking"
-      description="NRIC numbers are masked by default; only the last 4 characters will be displayed and collected (e.g. S7914578N appears as *****578N)"
+      label="Enable NRIC/FIN masking"
+      description="Only the last 4 characters will be displayed on your form and collected in the CSV (e.g. S7914578N appears as *****578N)"
       onChange={handleToggleNricMask}
     />
   )