Skip to content

Commit

Permalink
Merge pull request #7950 from opengovsg/release-v6.166.1
Browse files Browse the repository at this point in the history
build: release v6.166.1
  • Loading branch information
kevin9foong authored Nov 27, 2024
2 parents ea8401c + 844ee29 commit b9a555d
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 6 deletions.
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,21 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v6.166.1](https://github.com/opengovsg/FormSG/compare/v6.166.1...v6.166.1)

- fix: trim previous text responses [`#7949`](https://github.com/opengovsg/FormSG/pull/7949)

#### [v6.166.1](https://github.com/opengovsg/FormSG/compare/v6.166.0...v6.166.1)

> 27 November 2024

- build: release v6.166.0 [`#7945`](https://github.com/opengovsg/FormSG/pull/7945)
- chore: bump version to v6.166.1 [`18d9c74`](https://github.com/opengovsg/FormSG/commit/18d9c74cde8739bc96a0833f3764cb518e4e34aa)

#### [v6.166.0](https://github.com/opengovsg/FormSG/compare/v6.165.0...v6.166.0)

> 26 November 2024

- feat(mrf): conditional routing [`#7804`](https://github.com/opengovsg/FormSG/pull/7804)
- fix: trim text input before sending to backend [`#7937`](https://github.com/opengovsg/FormSG/pull/7937)
- test(story): add chromatic story to ensure thankyou page renders [`#7264`](https://github.com/opengovsg/FormSG/pull/7264)
Expand All @@ -19,6 +32,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- build: release v6.165.0 [`#7928`](https://github.com/opengovsg/FormSG/pull/7928)
- build: release v6.165.0 [`#7927`](https://github.com/opengovsg/FormSG/pull/7927)
- feat(i18n): extract text for form metadata [`#7926`](https://github.com/opengovsg/FormSG/pull/7926)
- chore: bump version to v6.166.0 [`c51e807`](https://github.com/opengovsg/FormSG/commit/c51e8074cce5ca0d5ac3ae4904e1c48ee94f5ec0)

#### [v6.165.0](https://github.com/opengovsg/FormSG/compare/v6.164.0...v6.165.0)

Expand Down
4 changes: 2 additions & 2 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "form-frontend",
"version": "6.166.0",
"version": "6.166.1",
"homepage": ".",
"type": "module",
"private": true,
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "FormSG",
"description": "Form Manager for Government",
"version": "6.166.0",
"version": "6.166.1",
"homepage": "https://form.gov.sg",
"authors": [
"FormSG <[email protected]>"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,17 @@ export const validateMultirespondentSubmission = async (
const incomingResField = req.body.responses[fieldId]
const prevResField = previousResponses[fieldId]

if (
prevResField.fieldType === BasicField.ShortText ||
prevResField.fieldType === BasicField.LongText
) {
// NOTE: LEGACY ISSUE
// Since text fields were saved without trimming prior to https://github.com/opengovsg/FormSG/pull/7937.
// Without this, isFieldResponseV3Equal fails since the prevResField was not trimmed,
// causing a mismatch between the newly trimmed incomingResField.
prevResField.answer = prevResField.answer.trim()
}

const resp = isFieldResponseV3Equal(
incomingResField,
prevResField,
Expand Down

0 comments on commit b9a555d

Please sign in to comment.