feat(errors): revamp business logic error codes

opengovsg · Jun 26, 2024 · ce9af29 · ce9af29
1 parent 4ceb3d1
commit ce9af29
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/src/app/modules/core/core.errors.ts b/src/app/modules/core/core.errors.ts
@@ -7,8 +7,9 @@ export class ApplicationError extends Error {
    * Meta object to be logged by the application logger, if any.
    */
   meta?: unknown
+  errorCode?: number
 
-  constructor(message?: string, meta?: unknown) {
+  constructor(message?: string, meta?: unknown, errorCode?: number) {
     super()
 
     Error.captureStackTrace(this, this.constructor)
@@ -18,6 +19,7 @@ export class ApplicationError extends Error {
     this.message = message || 'Something went wrong. Please try again.'
 
     this.meta = meta
+    this.errorCode = errorCode
   }
 }
 

diff --git a/src/app/modules/form/form.errors.ts b/src/app/modules/form/form.errors.ts
@@ -29,7 +29,7 @@ export class PrivateFormError extends ApplicationError {
     message = 'If you think this is a mistake, please contact the agency that gave you the form link.',
     formTitle: string,
   ) {
-    super(message)
+    super(message, 1001)
     this.formTitle = formTitle
   }
 }

diff --git a/src/app/modules/form/public-form/public-form.controller.ts b/src/app/modules/form/public-form/public-form.controller.ts
@@ -1,5 +1,6 @@
 import { HttpStatusCode } from 'axios'
 import { celebrate, Joi, Segments } from 'celebrate'
+import tracer from 'dd-trace'
 import { StatusCodes } from 'http-status-codes'
 import { err, ok, Result } from 'neverthrow'
 import { UnreachableCaseError } from 'ts-essentials'
@@ -96,6 +97,12 @@ export const handleGetPublicForm: ControllerHandler<
     }
     const { errorMessage, statusCode } = mapRouteError(error)
 
+    if (error?.errorCode) {
+      tracer.dogstatsd.increment('errorsV2', 1, {
+        error_code: error.errorCode,
+      })
+    }
+
     // Specialized error response for PrivateFormError.
     // This is to maintain backwards compatibility with the middleware implementation
     if (error instanceof PrivateFormError) {
@@ -105,6 +112,9 @@ export const handleGetPublicForm: ControllerHandler<
         // showing.
         isPageFound: true,
         formTitle: error.formTitle,
+        ...(error.errorCode !== undefined
+          ? { error_code: error.errorCode }
+          : {}),
       })
     }
 

diff --git a/src/app/modules/submission/email-submission/email-submission.controller.ts b/src/app/modules/submission/email-submission/email-submission.controller.ts
@@ -1,3 +1,4 @@
+import tracer from 'dd-trace'
 import { ok, okAsync, ResultAsync } from 'neverthrow'
 
 import {
@@ -440,6 +441,11 @@ const submitEmailModeForm: ControllerHandler<
         },
       )
       .mapErr((error) => {
+        if (error?.errorCode) {
+          tracer.dogstatsd.increment('errorsV2', 1, {
+            error_code: error.errorCode,
+          })
+        }
         const { errorMessage, statusCode } = mapRouteError(error)
         return res
           .status(statusCode)