update test cases for user controller

opengovsg · Jun 4, 2024 · d6a822d · d6a822d
1 parent 5bd7089
commit d6a822d
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/app/modules/user/__tests__/user.controller.spec.ts b/src/app/modules/user/__tests__/user.controller.spec.ts
@@ -8,18 +8,18 @@ import {
   MissingUserError,
 } from 'src/app/modules/user/user.errors'
 import * as UserService from 'src/app/modules/user/user.service'
-import { SmsSendError } from 'src/app/services/sms/sms.errors'
-import { SmsFactory } from 'src/app/services/sms/sms.factory'
+import { SmsSendError } from 'src/app/services/postman-sms/postman-sms.errors'
+import PostmanSmsService from 'src/app/services/postman-sms/postman-sms.service'
 import { HashingError } from 'src/app/utils/hash'
 import { IPopulatedUser } from 'src/types'
 
 import { DatabaseError } from '../../core/core.errors'
 import { UNAUTHORIZED_USER_MESSAGE } from '../user.constant'
 
 jest.mock('src/app/modules/user/user.service')
-jest.mock('src/app/services/sms/sms.factory')
+jest.mock('src/app/services/postman-sms/postman-sms.service')
 const MockUserService = jest.mocked(UserService)
-const MockSmsFactory = jest.mocked(SmsFactory)
+const MockPostmanSmsService = jest.mocked(PostmanSmsService)
 
 describe('user.controller', () => {
   afterEach(() => {
@@ -48,7 +48,9 @@ describe('user.controller', () => {
 
       // Mock UserService and SmsFactory to pass without errors.
       MockUserService.createContactOtp.mockReturnValueOnce(okAsync(expectedOtp))
-      MockSmsFactory.sendAdminContactOtp.mockReturnValueOnce(okAsync(true))
+      MockPostmanSmsService.sendAdminContactOtp.mockReturnValueOnce(
+        okAsync(true),
+      )
 
       // Act
       await UserController._handleContactSendOtp(MOCK_REQ, mockRes, jest.fn())
@@ -59,7 +61,7 @@ describe('user.controller', () => {
         MOCK_REQ.body.userId,
         MOCK_REQ.body.contact,
       )
-      expect(MockSmsFactory.sendAdminContactOtp).toHaveBeenCalledWith(
+      expect(MockPostmanSmsService.sendAdminContactOtp).toHaveBeenCalledWith(
         MOCK_REQ.body.contact,
         expectedOtp,
         MOCK_REQ.body.userId,
@@ -133,7 +135,7 @@ describe('user.controller', () => {
       // Mock UserService to pass without errors.
       MockUserService.createContactOtp.mockReturnValueOnce(okAsync('123456'))
       // Mock SmsFactory to return error.
-      MockSmsFactory.sendAdminContactOtp.mockReturnValueOnce(
+      MockPostmanSmsService.sendAdminContactOtp.mockReturnValueOnce(
         errAsync(new SmsSendError(mockErrorString)),
       )