fix: rm fallback from submit v2.1 mutation #6778
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fallback for virus can mutation catches all errors. This is an issue as when malicious files are scanned, the fallback is triggered as well. This bug was identified by @KenLSM in #6777.
Solution
There are many points of failure for the mutation to fail. The original intention of the fallback mechanism is to try the submission again if there are any unexpected errors related to the virus scan itself (e.g. if lambda is down, if s3 uploads can't be done, etc). However, these block submissions anyway - the response to this should be to rollback using the growthbook flag.
As such, we want to remove the
onError
block.Breaking Changes
Bug Fixes:
Tests