Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.82.0 #6800

Merged
merged 9 commits into from
Oct 16, 2023
Merged

build: release v6.82.0 #6800

merged 9 commits into from
Oct 16, 2023

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Oct 16, 2023

New

  • chore: improve nric/fin error message #6796
  • fix(gogov): reset GoGov states in share modal #6776
  • fix: add payment data to virus scanner endpoint #6789
  • chore: return InvalidFileKeyError if file not found #6787
  • feat(virus-scanner): happy path logging #6779
  • build: merge release v6.81.0 into develop #6780
  • chore(ci): backend jest config #6772
  • build: release v6.81.0 #6777
  • chore: bump version to v6.82.0 5dab965

Dependencies

  • fix(deps): bump type-fest from 4.3.1 to 4.4.0 in /shared #6782

Dev-Dependencies

Tests

chore: improve nric/fin error message #6796

@wanlingt

  • Create NRIC/FIN field, submit invalid FIN, should see 'Please enter a valid NRIC/FIN'

fix(gogov): reset GoGov states in share modal #6776

@sebastianwzq

Testing Share Form Modal on dashboard

  • Go to dashboard page
  • Fetch a gogov link
  • Ensure that other forms without gogov link do not replicate the same suffix as the created link
  • Refresh page
  • Go to any form with a gogov link
  • Go to any other form without a gogov link
  • The gogov link suffix should be empty

Testing invalidating gogov queries

  • Go to form page of a form without gogov link
  • Create a go gov link
  • Go back to dashboard page
  • Open share form modal of the form above
  • Gogov link should be present
  • Go back to form page of the form above
  • Open share form modal
  • Gogov link should be present

Regression test

  • Go to FormPage of a form with gogov link
  • Open share modal
  • Ensure gogov link is correct
  • Go to FormPage of a form without gogov link
  • Open share modal
  • Ensure no gogov link

fix: add payment data to virus scanner endpoint #6789

@KenLSM

  • Create a payment form with recaptcha.
  • Try to submit the payment form. It should succeed.

feat(virus-scanner): happy path logging #6779

@KenLSM

  • Ensure that you have a form that has virus scanner enabled (i.e. on staging, enable virus scanner for all forms, or on prod, use the form with the forced rule to enable it).
  • Go to a form that has virus scanner enabled. Open the network panel.
    • Submit a response with a non-malicious file.
    • Check the network panel - the payload should have version 2.1.
    • Go to datadog Logs and search for service:formsg source:cloudwatch @dd.env:staging-alt2 . You should see the following logs, in order:
      • Virus scanner is enabled on both BE and FE.
      • Successfully parsed success payload from virus scanning lambda
      • Successfully scanned and downloaded clean attachments
      • Saved submission to MongoDB
      • POST /api/v3/forms/651ad8aec300f7001132c2d2/submissions/storage
  • Go to a form that has virus scanner enabled again. Open the network panel.
    • Submit a response with a test malicious file. (Get one from https://www.eicar.org/download-anti-malware-testfile/)
    • Check the network panel - there should be 1 with version 2.1 in the payload and another with version 2 in the payload.
    • Go to datadog Logs and search for service:formsg source:cloudwatch @dd.env:staging-alt2 . You should see the following logs, in order:
      • The first API call to the virus scan enabled endpoint:
        • Virus scanner is enabled on both BE and FE.
        • Successfully parsed success payload from virus scanning lambda
        • Error returned from virus scanning lambda or parsing lambda output
        • Error scanning and downloading clean attachments (opening this, you should see an error message specifying which file failed the scan)
        • POST /api/v3/forms/651ad8aec300f7001132c2d2/submissions/storage
      • The second API call to the virus scan disabled endpoint:
        • Virus scanner is not enabled on FE.
        • Saved submission to MongoDB
        • POST /api/v3/forms/651ad8aec300f7001132c2d2/submissions/storage

KenLSM and others added 9 commits October 5, 2023 18:35
* fix: add ci mode, ci mode runs test in band to avoid context switch

* fix: ci crashing due to oom

* fix: increase ci worker count

* Revert "fix: ci crashing due to oom"

This reverts commit dff5171.

* feat: set workeridlememorylimit to 0.4

* feat: set workeridlememorylimit to 0.2
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.3.1...v4.4.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release v6.81.0 into develop
* feat: add dd logs for when virus scan succeeds

* feat: dd logs for virus scanner flags

* feat: dd logs for version in req.body

* revert: feat: dd logs for version in req.body

This reverts commit 48b2fd6.
* chore: return InvalidFileKeyError if file not found

* chore: improve error message

* chore: improve error message

Co-authored-by: Lin Huiqing <[email protected]>

---------

Co-authored-by: Lin Huiqing <[email protected]>
* fix: add payment data to virus scanner endpoint

* chore: add missing callback deps

* chore: replace stray 2.1s with constants

* fix: shared/constants import
* fix: reset GoGov states in share modal

* fix: invalidate all gogov calls after mutation

* fix: only invalidate query based on formId

* chore: remove unneeded useEffect dependency

* chore: use useEffect return cleanup

* fix: remove unneeded gogov key
@tshuli tshuli merged commit d850d31 into release-al2 Oct 16, 2023
80 of 89 checks passed
@tshuli tshuli deleted the release_v6.82.0 branch October 16, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants