Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.124.0 #7368

Merged
merged 8 commits into from
Jun 6, 2024
Merged

build: release v6.124.0 #7368

merged 8 commits into from
Jun 6, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jun 6, 2024

New

  • fix(submission): capture split error #7360
  • chore: remove unused deps #7336
  • feat(i18n): replace hardcoded text in login features #7344
  • feat(mockpass): enable admin login using mockpass locally #7359
  • build: merge release back to develop #7364
  • build: release v6.123.0 #7362

Dependencies

  • fix(deps): bump libphonenumber-js from 1.11.2 to 1.11.3 in /shared #7367

Dev-Dependencies

  • chore(deps-dev): bump prettier from 3.3.0 to 3.3.1 in /shared #7366

Tests

fix(submission): capture split error #7360

@g-tejas
As we cannot reproduce this error, the tests shall be regressive in nature.

Regression
  • Create a form with attachments
  • Submit the form with attachments
  • Observe that submission is successful

KenLSM and others added 8 commits June 5, 2024 16:19
build: merge release back to develop
* feat(mockpass): enable admin login using mockpass locally

Added functionality to allow admin login using NRIC S9812379B in mockpass when running the application locally.
This enhancement provides access to the select profile page for local development and testing.

* fix(lint): fix failing backend_lint job
* Added translation strings for en-sg locale for login features

* fix(i18n): decouple react-dom structure from en-sg locale

* fix(i18n): replace Trans component with useTranslation hook

---------

Co-authored-by: Sean  Chin <[email protected]>
Bumps [prettier](https://github.com/prettier/prettier) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.3.0...3.3.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7367)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.2 to 1.11.3.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.2...v1.11.3)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add test case when filename is null

* fix: check for nullish filename
@KenLSM KenLSM requested a review from g-tejas June 6, 2024 03:16
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KenLSM KenLSM merged commit 2d47adc into release-al2 Jun 6, 2024
47 of 48 checks passed
@KenLSM KenLSM deleted the release_v6.124.0 branch June 6, 2024 05:18
@g-tejas g-tejas mentioned this pull request Jun 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants