Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up external links #7439

Closed
wants to merge 1 commit into from

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jun 25, 2024

Problem

Closes [insert issue #]

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@g-tejas g-tejas marked this pull request as ready for review June 25, 2024 17:14
Copy link
Contributor Author

g-tejas commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @g-tejas and the rest of your teammates on Graphite Graphite

@g-tejas g-tejas marked this pull request as draft June 25, 2024 17:14
@KenLSM
Copy link
Contributor

KenLSM commented Jun 26, 2024

Hm for external constants, we might not want to make it dynamic. Would prefer to optimize for searchability rather over DRY.

@g-tejas
Copy link
Contributor Author

g-tejas commented Jun 26, 2024

Ahh okay that makes sense. Will delete this branch then

@g-tejas g-tejas closed this Jun 26, 2024
@KenLSM KenLSM deleted the 06-26-chore_tidy_up_external_links branch November 13, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants