Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.132.0 #7473

Merged
merged 10 commits into from
Jul 4, 2024
Merged

build: release v6.132.0 #7473

merged 10 commits into from
Jul 4, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jul 4, 2024 •
edited
Loading

New

  • chore: remove nric mask toggle if nricmask is false #7472
  • feat(i18n): replace hardcoded text in PublicFormSubmitButton #7427
  • fix(encrypt-submission): add missing ndi response fields #7425
  • build: merge release v6.131.0 to develop #7460
  • build: release v6.131.0 #7459

Dependencies

  • fix(deps): bump type-fest from 4.20.1 to 4.21.0 in /shared #7468
  • fix(deps): bump @babel/runtime from 7.24.1 to 7.24.7 #7466
  • fix(deps): bump validator and @types/validator #7440

Dev-Dependencies

  • chore(deps-dev): bump prettier from 3.2.5 to 3.3.2 #7465
  • chore(deps-dev): bump @types/compression from 1.7.2 to 1.7.5 #7464

Tests

fix(encrypt-submission): add missing ndi response fields #7425

Without NRIC Masking

  • 1. Create storage mode form, and add admin emails.
  • 2. Add my info fields and make form public
  • 3. Fill in a form and submit
  • 4. Receive email and observe that the sgID Validated NRIC field exists. The NRIC must be unmasked

With NRIC Masking

  • 1. Create storage mode form, and add admin emails.
  • 2. Enable NRIC Masking
  • 3. Add my info fields and make form public
  • 4. Fill in a form and submit
  • 5. Receive email and observe that the sgID Validated NRIC field exists. The NRIC in the email must be masked

kevin9foong and others added 10 commits July 1, 2024 15:32
@kevin9foong
Merge pull request #7460 from opengovsg/release-al2
f6a78c6 
build: merge release v6.131.0 to develop
@g-tejas
fix(encrypt-submission): add missing ndi response fields (#7425)
7c5f436 
* fix(encrypt-submission): add missing ndi response fields

* fix(tests): fix e2e testing for email notifs on encrypt-form

* fix: remove attachment tests temporarily

* fix: fix comment for email test

* test: add encrypt tests for nric masking in email notifs

* test: enable jest tests

* fix: fix comment for tests

* test: fix verifyEncryptSubmission test
@dependabot
fix(deps): bump validator and @types/validator (#7440)
91cedd3 
Bumps [validator](https://github.com/validatorjs/validator.js) and [@types/validator](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/validator). These dependencies needed to be updated together.

Updates `validator` from 13.7.0 to 13.12.0
- [Release notes](https://github.com/validatorjs/validator.js/releases)
- [Changelog](https://github.com/validatorjs/validator.js/blob/master/CHANGELOG.md)
- [Commits](validatorjs/validator.js@13.7.0...13.12.0)

Updates `@types/validator` from 13.7.10 to 13.12.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/validator)

---
updated-dependencies:
- dependency-name: validator
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: "@types/validator"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@paradite
feat(i18n): replace hardcoded text in PublicFormSubmitButton (#7427)
52f9aec
@dependabot
chore(deps-dev): bump @types/compression from 1.7.2 to 1.7.5 (#7464)
d3b45d2 
Bumps [@types/compression](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/compression) from 1.7.2 to 1.7.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/compression)

---
updated-dependencies:
- dependency-name: "@types/compression"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump prettier from 3.2.5 to 3.3.2 (#7465)
e62fa2b 
Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.3.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.2.5...3.3.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @babel/runtime from 7.24.1 to 7.24.7 (#7466)
1fd0744 
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.24.1 to 7.24.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.7/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump type-fest from 4.20.1 to 4.21.0 in /shared (#7468)
890bf69 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.20.1 to 4.21.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.20.1...v4.21.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kevin9foong
chore: remove nric mask toggle if nricmask is false (#7472)
3e48ffd
@KenLSM
chore: bump version to v6.132.0
82da6ac
@KenLSM KenLSM requested a review from g-tejas July 4, 2024 07:29
g-tejas
g-tejas approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KenLSM KenLSM merged commit bfa5421 into release-al2 Jul 4, 2024
47 of 49 checks passed
@KenLSM KenLSM deleted the release_v6.132.0 branch July 4, 2024 08:03
@KenLSM KenLSM mentioned this pull request Jul 7, 2024
Merged
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-tejas g-tejas g-tejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KenLSM @g-tejas @kevin9foong @paradite