Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copy for link to response page #7475

Closed
wants to merge 4 commits into from

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jul 4, 2024

Problem

Currrently, email mode notifications for encrypt forms do not have attachments as we plan on increasing the attachment size limit and other reasons. This PR makes it easy for admins to go from their email notifications to the settings page for downloading the attachments.

Screenshot 2024-07-07 at 5 23 02 PM

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression Test: Email mode form notifications must work exactly the same

  • 1. Create a new email mode form
  • 2. Make form public and create a submission
  • 3. Observe that the email notification arrives in inbox, and has the same format as before.
  • 4. Observe that the email notification has attachments attached.

New feature

  • 1. Create a new storage mode form
  • 2. Add your email as the admin
  • 3. Make form public and create a submission
  • 4. Observe that email notification arrives in inbox
  • 4. Observe that there's a link to the admin settings page, and the response Id and time should match exactly
  • 5. Observe that there are no attachments.

@g-tejas g-tejas marked this pull request as ready for review July 7, 2024 09:20
@g-tejas g-tejas requested review from KenLSM and kevin9foong and removed request for kevin9foong July 7, 2024 09:23
@g-tejas g-tejas marked this pull request as draft July 7, 2024 09:30
@@ -4,7 +4,12 @@
<body>
<p>Hello there,</p>
<p>A "<%= formTitle %>" form was submitted on <%= submissionTime %>.</p>
<br /><br /><br />
<% if (responseMode === 'encrypt') { %>
<p>View this submission and download attachments on <a href="http://localhost:3000/admin/form/<%= formId %>/results/<%= refNo %>">FormSG</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be careful of side effects when linking an authenticated url. We might need to exclude certain url groups from DD to avoid getting false positive alerts / betteruptime calls.

@g-tejas g-tejas force-pushed the feat/email-notifs-attachment-link branch from 2597e8d to a373538 Compare July 16, 2024 02:45
@g-tejas g-tejas closed this Aug 8, 2024
@KenLSM KenLSM deleted the feat/email-notifs-attachment-link branch November 13, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants