Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.134.0 #7498

Merged
merged 15 commits into from
Jul 11, 2024
Merged

build: release v6.134.0 #7498

merged 15 commits into from
Jul 11, 2024

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jul 11, 2024 •
edited by kevin9foong
Loading

New

  • feat(errors): revamp business logic error codes #7443
  • fix: fix issue where attachments would fail locally #7496
  • feat(i18n): replace hardcoded string values for AdminFormNavbar #7456
  • build: merge release v6.133.0 to develop #7494
  • build: release v6.133.0 #7483

Dependencies

  • fix(deps): bump helmet from 6.0.1 to 7.1.0 #7242
  • fix(deps): bump hot-shots from 9.3.0 to 10.0.0 #7490
  • fix(deps): bump html-entities from 2.3.3 to 2.5.2 #7489
  • fix(deps): bump fp-ts from 2.13.1 to 2.16.8 #7485

Dev-Dependencies

  • chore(deps-dev): bump lint-staged from 13.1.0 to 15.2.7 #7487
  • chore(deps-dev): bump supertest-session from 4.1.0 to 5.0.1 #7493
  • chore(deps-dev): bump @types/ejs from 3.1.1 to 3.1.5 #7492
  • chore(deps-dev): bump @types/sns-validator from 0.3.1 to 0.3.3 #7491
  • chore(deps-dev): bump eslint-plugin-jest from 28.5.0 to 28.6.0 #7484

Tests

feat(errors): revamp business logic error codes #7443

  • 1. Create a form and keep it private
  • 2. Open datadog dashboard on staging
  • 3. Get the public form url and spam 4xxs by opening the website
  • 4. Observe that the traces on datadog are marked with the appropriate error codes. For e.g, Private form errors are 100000 code.

fix: fix issue where attachments would fail locally #7496

Regression Tests

  • 1. Create a storage mode form
  • 2. Add attachments field
  • 3. Make form public
  • 4. Make a submission to the form
  • 5. Go form responses page
  • 6. Observe that responses contains attachments
  • 7. Repeat for email mode forms

New environment variables:

  • AWS_ENDPOINT : updated to 127.0.0.1 instead.

dependabot bot and others added 15 commits July 7, 2024 17:22
@dependabot
chore(deps-dev): bump eslint-plugin-jest from 28.5.0 to 28.6.0 (#7484)
f9e9c25 
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 28.5.0 to 28.6.0.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v28.5.0...v28.6.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump fp-ts from 2.13.1 to 2.16.8 (#7485)
34c550e 
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.13.1 to 2.16.8.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gcanti/fp-ts/commits)

---
updated-dependencies:
- dependency-name: fp-ts
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump html-entities from 2.3.3 to 2.5.2 (#7489)
aa94717 
Bumps [html-entities](https://github.com/mdevils/html-entities) from 2.3.3 to 2.5.2.
- [Release notes](https://github.com/mdevils/html-entities/releases)
- [Changelog](https://github.com/mdevils/html-entities/blob/master/CHANGELOG.md)
- [Commits](mdevils/html-entities@v2.3.3...v2.5.2)

---
updated-dependencies:
- dependency-name: html-entities
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/sns-validator from 0.3.1 to 0.3.3 (#7491)
a8f8323 
Bumps [@types/sns-validator](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sns-validator) from 0.3.1 to 0.3.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sns-validator)

---
updated-dependencies:
- dependency-name: "@types/sns-validator"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/ejs from 3.1.1 to 3.1.5 (#7492)
174fb82 
Bumps [@types/ejs](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ejs) from 3.1.1 to 3.1.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ejs)

---
updated-dependencies:
- dependency-name: "@types/ejs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@KenLSM
Merge pull request #7494 from opengovsg/release-al2
b506433 
build: merge release v6.133.0 to develop
@helloitsxinyi @KenLSM
feat(i18n): replace hardcoded string values for AdminFormNavbar (#7456)
a79f783 
feat(i18n): add en-sg translations and types for admin-form-navbar, use translations in AdminFormNavbar

Co-authored-by: Ken Lee Shu Ming <[email protected]>
@g-tejas
fix: fix issue where attachments would fail locally
43e659b
@g-tejas
Merge pull request #7496 from opengovsg/fix/attachment-failing
bf60a01 
fix: fix issue where attachments would fail locally
@dependabot
fix(deps): bump hot-shots from 9.3.0 to 10.0.0 (#7490)
d3a1344 
Bumps [hot-shots](https://github.com/brightcove/hot-shots) from 9.3.0 to 10.0.0.
- [Changelog](https://github.com/brightcove/hot-shots/blob/master/CHANGES.md)
- [Commits](brightcove/hot-shots@v9.3.0...v10.0.0)

---
updated-dependencies:
- dependency-name: hot-shots
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump supertest-session from 4.1.0 to 5.0.1 (#7493)
929a166 
Bumps [supertest-session](https://github.com/rjz/supertest-session) from 4.1.0 to 5.0.1.
- [Commits](rjz/supertest-session@v4.1.0...v5.0.1)

---
updated-dependencies:
- dependency-name: supertest-session
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump lint-staged from 13.1.0 to 15.2.7 (#7487)
4896690 
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.1.0 to 15.2.7.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v13.1.0...v15.2.7)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@g-tejas
feat(errors): revamp business logic error codes (#7443)
c222ba0 
* feat(errors): revamp business logic error codes

* feat: refactor existing error objects to use new error codes

* fix: change gogov error object constructor

* fix: fix webhook error obj

* fix: fix failing backend lint

* feat: add error code span tagging to some controllers

* feat: add unauthorized error

* docs: remove unncessary comment

* fix: remove error codes from sms.*

* refactor: organise into block groups based on origin

* fix: make error code names SCREAMING_SNAKE_CASE

* fix: make auth middleware create error object

* fix: rename all error codes to screaming snake case

* fix: fix test:backend failing with prefixed message

* fix: rename remaining error code to screaming snake case

* fix: fix failing tests due to wrong err msg

* fix: remove dd tag setting from controllers

* tests: add tests for error codes

* fix: fix spacing
@dependabot @KenLSM
fix(deps): bump helmet from 6.0.1 to 7.1.0 (#7242)
0e85520 
* fix(deps): bump helmet from 6.0.1 to 7.1.0

Bumps [helmet](https://github.com/helmetjs/helmet) from 6.0.1 to 7.1.0.
- [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md)
- [Commits](helmetjs/helmet@v6.0.1...v7.1.0)

---
updated-dependencies:
- dependency-name: helmet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: typing on helmet

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ken <[email protected]>
@g-tejas
chore: bump version to v6.134.0
8d77390
@g-tejas g-tejas requested review from KenLSM and kevin9foong July 11, 2024 08:41
kevin9foong
kevin9foong approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. manual tests work

@g-tejas g-tejas merged commit 73c67ee into release-al2 Jul 11, 2024
50 of 52 checks passed
@g-tejas g-tejas deleted the release_v6.134.0 branch July 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin9foong kevin9foong kevin9foong approved these changes

@KenLSM KenLSM Awaiting requested review from KenLSM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g-tejas @kevin9foong @KenLSM @helloitsxinyi