feat: switch delete to edit button on logic page #7887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Destructive actions should be hidden below the fold; this is a baseline practice in UX
Closes FRM-1906
Solution
<TrashIcon />
with<PencilIcon />
Breaking Changes
Before & After Screenshots
Tests
Regression
Edit logic can be triggered
<PencilIcon />
can be clicked<PencilIcon />
does not enter edit modeEditing another input should not be allowed if already in edit mode
<PencilIcon />
to enter edit mode