feat: address field #7966
Draft
feat: address field #7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 1903 Passed, 1 Skipped, 4m 0.12s Total duration (2m 46.37s time saved) |
merged with develop
KenLSM
reviewed
Dec 20, 2024
| [BasicField.Address]: { | ||
| label: 'Local address', | ||
| icon: SlLocationPin, | ||
| isSubmitted: true, |
There was a problem hiding this comment.
/nit Regarding searchAliases: to get input from Ruchel + Kenneth before we release.
KenLSM
reviewed
Dec 20, 2024
| @@ -135,7 +135,6 @@ const transformFormInputCountryRegionToUpperCase = | |||
| .filter((field) => field.fieldType === BasicField.CountryRegion) | |||
| .map((field) => field._id), | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Accidental change here? It should be fine to leave a visual break here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT - checking chromatic PR updates
Problem
Closes [insert issue #]
Solution
Breaking Changes
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER:
Tests
Deploy Notes
New environment variables:
env var: env var detailsNew scripts:
script: script detailsNew dependencies:
dependency: dependency detailsNew dev dependencies:
dependency: dependency details