Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(myinfo): replace node-jose with jose for SSO #563

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

amandalim857
Copy link
Contributor

Problem

Replace node-jose package with jose for myInfo SSO.

Addresses part of Issue #328
Left to resolve use of library in sgID, spcp and v2-ndi files.

Solution

Replace node-jose with jose library for encryption and signing of data.

@LoneRifle LoneRifle changed the title refactor(myinfo): replace node-jose with jose for SSO (opengovsg#328) refactor(myinfo): replace node-jose with jose for SSO Jul 12, 2023
Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LoneRifle LoneRifle merged commit d01a672 into opengovsg:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants