Apply suggestions from code review

Co-authored-by: lsiepel <[email protected]> Signed-off-by: Cody Cutrer <[email protected]>
openhab · Oct 7, 2024 · 1322461 · 1322461
1 parent 603a0d3
commit 1322461
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...in/java/org/openhab/binding/mqtt/homeassistant/internal/component/DefaultSchemaLight.java b/...in/java/org/openhab/binding/mqtt/homeassistant/internal/component/DefaultSchemaLight.java
@@ -297,8 +297,8 @@ public void updateChannelState(ChannelUID channel, State state) {
         // channel. all the rest we can just check against the basic ID
         if (channel.equals(onOffChannel.getChannel().getUID())) {
             if (localColorChannel != null) {
-                HSBType newOnState = colorValue.getChannelState() instanceof HSBType
-                        ? (HSBType) colorValue.getChannelState()
+                HSBType newOnState = colorValue.getChannelState() instanceof HSBType newOnStateTmp
+                        ? newOnStateTmp
                         : HSBType.WHITE;
                 if (state.equals(OnOffType.ON)) {
                     colorValue.update(newOnState);
@@ -314,8 +314,7 @@ public void updateChannelState(ChannelUID channel, State state) {
         } else if (localBrightnessChannel != null && localBrightnessChannel.getChannel().getUID().equals(channel)) {
             onOffValue.update(Objects.requireNonNull(state.as(OnOffType.class)));
             if (localColorChannel != null) {
-                if (colorValue.getChannelState() instanceof HSBType) {
-                    HSBType hsb = (HSBType) (colorValue.getChannelState());
+                if (colorValue.getChannelState() instanceof HSBType hsb) {
                     colorValue.update(new HSBType(hsb.getHue(), hsb.getSaturation(),
                             (PercentType) brightnessValue.getChannelState()));
                 } else {

diff --git a/...va/org/openhab/binding/mqtt/homeassistant/internal/handler/HomeAssistantThingHandler.java b/...va/org/openhab/binding/mqtt/homeassistant/internal/handler/HomeAssistantThingHandler.java
@@ -184,7 +184,7 @@ public void initialize() {
 
                 addComponent(component);
             } catch (ConfigurationException e) {
-                logger.error("Cannot restore component {}: {}", thing, e.getMessage());
+                logger.warn("Cannot restore component {}: {}", thing, e.getMessage());
             }
         }
         if (updateThingType(typeID)) {