Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [dirigera] Initial contribution #17719

Open
wants to merge 125 commits into
base: main
Choose a base branch
from
Open

[WIP] [dirigera] Initial contribution #17719

wants to merge 125 commits into from
+37,133 −23

Conversation

weymann
Copy link
Contributor

@weymann weymann commented Nov 7, 2024

Binding for IKEA DIRIGERA hub for smart products.

The work ist still in progress but I would like to start the review to find breaking changes right now and not at the end, e.g. thing and channel names.

The binding is published on Marketplace and Community Discussion is active.

@weymann weymann requested a review from a team as a code owner November 7, 2024 21:42
@lsiepel lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Nov 8, 2024
lsiepel
lsiepel requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at the thing-structure.xml files as you wanted early feedback.

I did not repeat the same comments for multiple Things. As this seems a well strucutered binding, i think it would be easy for you to project my comments on the other Things.

Extra note, please user system state channels where possible:
https://www.openhab.org/docs/developer/bindings/thing-xml.html#system-state-channel-types

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/air-purifier.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/air-purifier.xml
<label>Custom Name</label>
<description>Name given from IKEA home smart</description>
</channel>
<channel id="ota-status" typeId="ota-status">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between state and status in this case?
Applies to multiple Things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also needed to Google this :)

otaStatus and otaState derived from working repository

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/blind.xml
<description>Window or door blind</description>

<channels>
<channel id="blind-state" typeId="blind-state">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this state id future proof? Currently it only seems to accept up/down/stopped, but would it also be usable for top-down / bottom-up or other variants? Not sure if this makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why it's designed as a number with mappings which can be extended.

Also here these values are not coming out of the blue.

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/blind.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/channel-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/channel-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/sound-controller.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/speaker.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/speaker.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/temperature-light.xml Outdated Show resolved Hide resolved
@weymann
Copy link
Contributor Author

weymann commented Nov 13, 2024

@lsiepel
Thanks for the fast reply - I'll start now working on this.

@weymann
initial commit
24e55c5 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
initial commit
50f66c9 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
framework is running
d41a437 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
rebase fix
8c141b9 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add motion sensor
69b19b9 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add light sensor
232e442 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
rebase fix
d6c243e 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add temperature light
95d8fdb 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add smart plug
5e4bc04 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add device speaker
fe58c44 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
bugfixing speaker device
a298c4d 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
prepare unit tests
482dc87 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
make discovery configurable
6b518a3 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add test files
b32fa02 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add test files
7595430 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add ota channels
2c9efb1 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add ota channels
80e8afc 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
hub channels
906f3e3 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add scene handler
b059283 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
ping pong tryout
0a3bb82 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add repeater device
cf9aec6 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add repeater device
6717ba5 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add lightcontroller device
cf23644 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add lightcontroller device
1d8648e 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
heartbeat finished
e7626b3 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
motion-light-sensor added
a263d4a 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
light rework
8707fac 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
light rework
861ea47 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
finally handling to esnure freeing resources after queue access
2a39d25 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
channel adaptions from review
7d35ebb 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
channel updates
d3c3c72 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
color channel fix
579ee3c 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add gateway location channel
37f710d 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add coordinates channel and channel updates
f47fd0e 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add receive and send capabilities
e941c21 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
correct light identification
42bbfed 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add switch light
b128a63 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add switch light
6d17f93 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
inspelning reset handling
ca14efc 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
inspelning reset handling
d1ba3ec 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
bugfixes exceptions during error handling
736982d 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
imrpove exception handling in api
341a7fa 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
watchdog first version
7f91996 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add air purifier fan speed channel
0d6efe5 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
bugfix air purifier after testing
90fb6ed 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
readme adaptions
af3856f 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
enhance readme
231c155 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add device dump action
185b20d 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add debug actions
16605f5 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
channel cleanup
68c7baa 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
correct version
acedd42 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
translations
b3bf3c2 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann weymann requested a review from lsiepel December 1, 2024 22:37
@weymann
Copy link
Contributor Author

weymann commented Dec 1, 2024

@lsiepel
All channel adaptions done which shall be now in a stable status.
Binding is running for several community members who reported positive results for several devices. Stability improved with watchdog running.

I don't forsee changes in architecture, class structure and general behavior. Only in specific device handlers if bugfixes are necessary. So I would ask to extend the review on code. Leave logging out of scope, this is still messy and I'm still working on that.

@weymann
fix channel typo
e6b15f1 
Signed-off-by: Bernd Weymann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel Awaiting requested review from lsiepel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weymann @lsiepel