Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[digiplex] Fix exception handling in sender and receiver threads #17829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmichalak
Copy link

Improves error handling in sender and receiver threads so that the threads do not occasionally stop when an unexpected exception occurs.

Closes #17828

@rmichalak rmichalak force-pushed the 17828-improve-digiplex-error-handling branch from 416f9d4 to b9cbdec Compare December 1, 2024 14:12
@rmichalak rmichalak force-pushed the 17828-improve-digiplex-error-handling branch from b9cbdec to 2d6ab72 Compare December 1, 2024 14:16
@jlaur
Copy link
Contributor

jlaur commented Dec 3, 2024

Improves error handling in sender and receiver threads so that the threads do not occasionally stop when an unexpected exception occurs.

Which unexpected exception have you observed?

@rmichalak
Copy link
Author

Improves error handling in sender and receiver threads so that the threads do not occasionally stop when an unexpected exception occurs.

Which unexpected exception have you observed?

Honestly, I don't remember now. I'm the original author of this binding and I had this fix applied in my environment for a long time (just forgot to push it to remote). As far as I remember, my alarm system is sending some rubbish over RS232 from time to time and then parsing may fail in many unexpected ways. that's why I have this handleCommunicationError function which reinitializes everything.

@lolodomo lolodomo added rebuild Triggers Jenkins PR build bug An unexpected problem or unintended behavior of an add-on and removed rebuild Triggers Jenkins PR build labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[digiplex] Received thread stops when an exception happens inside
3 participants