[vesync] Core 300S Updates #17842
Draft
[vesync] Core 300S Updates #17842
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[vesync] Core 300S Updates Signed-off-by: David Goodyear <[email protected]>
[vesync] Cleanup Signed-off-by: David Goodyear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vesync] Core 300S Updates
This updates the device profile for the core 300S. This aligns the fan speeds and modes now provided in pyvesync, as the device limitations. It looks like since the initial ports the range and modes specified for the device have been updated.
This change adds the auto mode as a valid payload for the protocol to allow for this device, and increases the range from 1...3 to 1...5.
This relates to OpenHab issue: [#16456] (#16456) I have requested on that thread the user confirms operation as expected, given these new parameters ported from pyvesync.