[basicprofiles] Add $DELTA_PERCENT function to State Filter profile #17843
+78
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Tanagra <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/state-filter-range-filter-profile/158025/24 |
Signed-off-by: Jimmy Tanagra <[email protected]>
lsiepel
reviewed
Dec 4, 2024
Comment on lines
+686
to
+688
| if (deltaState instanceof QuantityType deltaStateQuantity) { | ||
| // Assume that delta and base are in the same unit | ||
| bdDelta = ((QuantityType) stateDelta).toBigDecimal(); |
There was a problem hiding this comment.
This is somewhat confusing and possibly wrong.
- The method starts with assigning
stateDeltabut deos not seem to be used later on. - Iin line 686
deltaState(reverse name?!) is used with instanceof - The var
deltaStateQuantitycreated with the instanceof is not used. - Within the instanceof block another case is done.
((QuantityType) stateDelta)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
$DELTA_PERCENT > 5or simply> 5%