Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize thread names (2) #17849

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Normalize thread names (2) #17849

merged 3 commits into from
Dec 5, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Dec 5, 2024

See also #17804

Signed-off-by: AndrewFG [email protected]

@andrewfg
Normalize thread names
eb1749b 
Signed-off-by: AndrewFG <[email protected]>
@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Dec 5, 2024
@andrewfg andrewfg self-assigned this Dec 5, 2024
@andrewfg andrewfg requested a review from lsiepel December 5, 2024 17:44
@andrewfg
simplify id
f98e867 
Signed-off-by: AndrewFG <[email protected]>
@andrewfg andrewfg removed the work in progress A PR that is not yet ready to be merged label Dec 5, 2024
@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 5, 2024

@lsiepel I marked this as draft to reflect the state of #17804 .. however I think it is essentially ready for review .. but I will wait until you tell me to release it..

@andrewfg andrewfg marked this pull request as ready for review December 5, 2024 19:44
lsiepel
lsiepel approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all 43 files, LGTM.

@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 5, 2024

Checked all 43 files

Just so you know: the 'extends Thread' search did as you say reveal 57 such cases; however a few of them did already implement the agreed normalised thread naming convention.

@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 5, 2024

@lsiepel I don't know why one of the three CI java builds failed here. It could be an instability in one of the tests (wemo binding)

kabili207
kabili207 approved these changes Dec 5, 2024
View reviewed changes
Copy link

@kabili207 kabili207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 388dc6b into openhab:main Dec 5, 2024
3 of 5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Dec 5, 2024
@lsiepel lsiepel removed the enhancement An enhancement or new feature for an existing add-on label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@kabili207 kabili207 kabili207 approved these changes

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@roieg roieg Awaiting requested review from roieg roieg is a code owner

@nokyyz nokyyz Awaiting requested review from nokyyz nokyyz is a code owner

@olivierkeke olivierkeke Awaiting requested review from olivierkeke olivierkeke is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@dalgwen dalgwen Awaiting requested review from dalgwen dalgwen is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@Stratehm Stratehm Awaiting requested review from Stratehm Stratehm is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@stefanroellin stefanroellin Awaiting requested review from stefanroellin stefanroellin is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@ppieczul ppieczul Awaiting requested review from ppieczul ppieczul is a code owner

@Skinah Skinah Awaiting requested review from Skinah Skinah is a code owner

@Andy2003 Andy2003 Awaiting requested review from Andy2003 Andy2003 is a code owner

@rmichalak rmichalak Awaiting requested review from rmichalak rmichalak is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@BobRak BobRak Awaiting requested review from BobRak BobRak is a code owner

Assignees

@andrewfg andrewfg

Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewfg @kabili207 @lsiepel