-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update Smartthings binding for new API #17855
Open
lo92fr
wants to merge
44
commits into
openhab:main
Choose a base branch
from
lo92fr:smartthingsNG
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,725
−3,188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
remove template player.html change oauth scope Signed-off-by: Laurent ARNAL <[email protected]>
code cleaning (WIP) Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
WIP will need to implements ThingTypeProvider and ChannelTypeProvider to provide full support Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
automatic creation of smartapps from openhab (WIP) Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
…sion ==> WIP : need refactoring code to clarify the process Signed-off-by: Laurent ARNAL <[email protected]>
lolodomo
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Dec 9, 2024
add more Dto add more ApiCall handle api returning Array of type Remove old addons specific stuff Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
fix SmartthingsApi token retrieven Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
lo92fr
force-pushed
the
smartthingsNG
branch
from
December 11, 2024 13:22
0144137
to
2941426
Compare
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
channeType creation must be done before device detection from capabilities reading ! Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about rewriting the Smartthings addons that is not working anymore since a few month because of deep change in the samsung API.
This is link to issue : #16946
And also to discussion in communauty forum : https://community.openhab.org/t/smartthings-binding-eol/138750/19
This is currently work in progress.
What is working so far:
To start testing the new binding, you will need to create a samsung smartapp using the smarthings cli.
https://github.com/SmartThingsCommunity/smartthings-cli
This will be describe more in depth later, but you mainly need:
To create an OpenHab app :
smartthings apps:create
To configure OAuth for this app:
smartthings apps:oauth {myAppId}
To generate a clientId/clientSecret for this oauth:
smartthings apps:oauth:generate {myAppId]
You will get an answer like this one:
───────────────────────────────
Client Name Openhab
Scope r:locations:,r:devices:$,r:scenes:,w:installedapps,r:installedapps,w:rules:,x:scenes:,r:hubs:,r:rules:,x:devices:,w:devices:$,w:locations:,r:devices:,w:devices:,x:locations:*,x:devices:$
Redirect Uris https://api.smartthings.com/installedapp,https://localhost:8443/connectsmartthings
OAuth Client Id 39bf5964-xxxx-xxxx-xxxx-xxx
OAuth Client Secret efeabe17-xxxx-xxxx-xxxx-xxx
───────────────────────────────
You can after create the Smarthings Cloud Hub in Openhab, filling the clientId and clientSecret as parameters.
And then do a discovery scan to start using the binding.
Best regards,
Laurent.