-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Units] Add MK⁻¹ unit alias #4433
Conversation
Signed-off-by: AndrewFG <[email protected]>
@maniac103 for info.. |
Should we also be adding |
^ |
Signed-off-by: AndrewFG <[email protected]>
LGTM |
bundles/org.openhab.core/src/main/java/org/openhab/core/library/unit/Units.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AndrewFG <[email protected]>
I followed the discussion and it looks good to me too. |
If I have a String |
Umm. From memory I believe it is the following. .. But perhaps I should add a Junit test to confirm that works?
EDIT: whereby "yourString" has to contain a number rather than a pattern.. |
Signed-off-by: AndrewFG <[email protected]>
@lolodomo I just added the Junit test (it passes). PS and the code for checking a pattern match would be..
|
Or |
Oh yes, looks better, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The change was introduced in openhab/openhab-core#4433 Signed-off-by: Jimmy Tanagra <[email protected]>
See discussion openhab/openhab-addons#17638 (comment)
Signed-off-by: AndrewFG [email protected]