Update services.cfg #1697
Update services.cfg #1697
Conversation
fix services.cfg to re-enable startup level 30 in development environment Signed-off-by: lo92fr <[email protected]>
launch/app/runtime/services.cfg
Outdated
| #startlevel:30=persistence:restore // do not rely on the presence of a persistence service in the IDE | ||
| startlevel:20=dsl:items,managed:item,dsl:things,managed:thing,managed:itemchannellink,dsl:persist,managed:metadata | ||
| startlevel:30=persistence:services,persistence:restore,automation:scriptEngineFactories |
There was a problem hiding this comment.
What about the current comment ?
In IDE, we should be able to start openHAB even without any persistence installed.
Is it still the case with your change ?
There was a problem hiding this comment.
Hum, don't look at the comment, sorry.
So I don't know what are good modification to solve this.
The matter is that we add new marker as part of @J-N-K modification on September 9.
And we except to openhab go to level 30 to have ThingManagerImpl correctly initialized !
Laurent.
There was a problem hiding this comment.
Laurent,
This is related to the issue : openhab/openhab-core#3823.
Don't know if you see my comment this morning about tracing why we have thing not get initialized in development environment.
There was a problem hiding this comment.
Take care, you have two different lines for start level 20.
You have to keep only one.
There was a problem hiding this comment.
IMO you. eed to remove the second line for start level 20 and should remove the persistence:restore marker. The other two markers rely on bundle trackers and will be set when all installed bundles (persistence or scripting) are ACTIVE or no bundle of the given type is installed. persistence:restore in principle expects a persistence bundle to be installed which might not be the case in a development environment.
|
Tested with in Eclipse and I can confirm that our problem with managed things remaining in NOT_YET_READY status at startup is fixed. |
|
@openhab/distro-maintainers @openhab/core-maintainers : this is a critical fix to review ASAP, we are no more able since few weeks/months to use managed things when playing with Eclipse IDE. The current comment for start level 30 should also be considered. @lo92fr : please adjust your fix as you kept two lines for start level 20. |
launch/app/runtime/services.cfg
Outdated
| #startlevel:30=persistence:restore // do not rely on the presence of a persistence service in the IDE | ||
| startlevel:20=dsl:items,managed:item,dsl:things,managed:thing,managed:itemchannellink,dsl:persist,managed:metadata | ||
| startlevel:30=persistence:services,persistence:restore,automation:scriptEngineFactories |
There was a problem hiding this comment.
IMO you. eed to remove the second line for start level 20 and should remove the persistence:restore marker. The other two markers rely on bundle trackers and will be set when all installed bundles (persistence or scripting) are ACTIVE or no bundle of the given type is installed. persistence:restore in principle expects a persistence bundle to be installed which might not be the case in a development environment.
fix double line form startlevel:20, and remove persistence:restore on startlevel:30 Signed-off-by: lo92fr <[email protected]>
|
I just tried again with your last changes and I confirm that my managed thing is now ONLINE after start from Eclipse IDE. @kaikreuzer : can you please merge ? |
fix services.cfg to re-enable startup level 30 in development environment
Link to issue #3823 in openhab-core : openhab/openhab-core#3823