Fix access to context variables in UI rules #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
ui-context
branch
4 times, most recently
from
7f22f7b to
ea2e963
Compare
Signed-off-by: Jimmy Tanagra <[email protected]>
ccutrer
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133 implemented context access for when UI rules/scripts are manually run/triggered. We didn't encounter any issues for that particular method of execution, because there is no trigger module ID involved.
In UI based rules, $ctx keys are prepended with the module id of the trigger that triggered the rule execution (e.g. item state change), so currently the library won't find a match for, e.g.
eventbecause it's stored as$ctx["<moduleid>.event"]It appears that nobody is using this library for UI based rules, otherwise we would've received bug reports/complaints.