Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add planckian helpers for HSBType #353

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Oct 10, 2024

No description provided.

@ccutrer ccutrer force-pushed the planckian branch 2 times, most recently from cddab88 to 5a7efbe Compare October 10, 2024 20:05
@ccutrer ccutrer requested a review from jimtng October 10, 2024 20:10
@ccutrer ccutrer marked this pull request as ready for review October 11, 2024 16:32
Copy link
Contributor

@jimtng jimtng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should call it white_cct, because we're looking at the spectrum from warm white to cool white, as opposed to "color" (i.e. the rgb mode).

The reason being, the word "white" is more user friendly, less esoteric than "planck", and I think it conveys the meaning directly.

Also white? and color? (the inverse of white?)

lib/openhab/core/types/hsb_type.rb Outdated Show resolved Hide resolved
lib/openhab/core/types/hsb_type.rb Outdated Show resolved Hide resolved
@ccutrer ccutrer force-pushed the planckian branch 2 times, most recently from 7d21dcf to e3a8519 Compare October 28, 2024 20:23
@ccutrer
Copy link
Contributor Author

ccutrer commented Oct 28, 2024

I wonder if we should call it white_cct

I've added aliases white_cct and white_cct?

Also would be very handy to add HSBType::WARM_WHITE and HSBType::COOL_WHITE although, some define cool white as 5000K (but some call this daylight) and some 6500K.

Yeah... the variety of what one thinks is warm to cool is why I don't plan on doing this.

@ccutrer ccutrer merged commit f610bd2 into openhab:main Oct 28, 2024
21 checks passed
@ccutrer ccutrer deleted the planckian branch October 28, 2024 22:38
@jimtng jimtng added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants