[rules] SwitchableJSRule: Add option to specify name of Switch Item
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
SwitchableJSRule: Add ability to specify name of Switch ItemSwitchableJSRule: Add option to specify name of Switch Item
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Apr 11, 2024
Add missing release note for breaking change from openhab#325. Closes openhab#327. Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to the rule config for
SwitchableJSRuleto specify the name of the Switch Item, which enables and disables the rule.If no
switchItemNameis provided, the Item name will be generated as before.If the
switchItemNameis specified but no Item with the specified name exists, an Item with that name is created, else the existing Item with this name is used.BREAKING CHANGE: It also changes Item.type to not include the
Itemsuffix, i.e.SwitchItemnow is justSwitch.