-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev tvos #625
Open
mememe2167
wants to merge
24
commits into
openid:dev-tvos
Choose a base branch
from
mememe2167:dev-tvos
base: dev-tvos
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev tvos #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Code is from tree https://github.com/google/GTMAppAuth/tree/10d138eb05ad299fd6260741e7b92b0090db0963 - I contributed this code originally to GTMAppAuth on Dec 6, 2016 google/GTMAppAuth@2eb382f
- Add beginnings of 'AppAuthTV' Pod subspec - Remove dependency on `GTMAppAuthFetcherAuthorization` - Remove GTMAPPAUTH_USER_IMPORTS code - Verified with `pod lib lint`
* Rename OID to GTM, remove extra header * Remove TVConfigurationForGoogle, update copyright headers * Return OIDAuthState instead of GTMAppAuthFetcherAuthorization * Add AppAuthTV to Xcode targets, fix NSObject description method bug * Add files to AppAuthTV target * Remove property synthesize * Add AppAuthTVTests target, pointing to UnitTests/UnitTestsInfo.plist and included in AppAuthTV scheme. Reorder imports * Update min tvOS version and identifier for AppAuthTV target * Correct capitalization in AppAuthTV identifier * Update reference URLs, references to Google removed * Remove non-functioning AppAuthTVTests target (tests coming in future PR) * Fix indent spacing in OIDTVServiceConfiguration
* OIDTVAuthorizationRequest tests * Add tests to AppAuthTVScheme * add AppAuthTV to .travis.yml
Adds OIDTVTokenRequest class, which is a subclass of OIDTokenRequest, to better adhere to the [RFC for TV authentication](https://tools.ietf.org/html/rfc8628#section-3.4). This adds the required `device_code` property which is sent in the request body, which differs from the `code` property for the authorization code in the parent class. Additionally, the grant type for TV authorization is hard-coded in, and several unused fields are dropped from the initializer and body request code.
Update the example project to support discovery
…aximumSize: instead of #pragma
- Create a tvOS example README - Document tvOS support in main README - Link to tvOS example from the example README - Add Google IdP tvOS details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.