Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16u Public archive

8268127: Shenandoah: Heap size may be too small for region to align to large page size #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jun 11, 2021

I would like to backport this Shenandoah specific patch to 16u, which allows to fallback to regular pages for regions, if heap size is too small to allow regions to use large pages.

The original patch does not apply cleanly, resolved then manually.

Test:
Manually test to ensure large pages are used. Failed w/o the patch and passed with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268127: Shenandoah: Heap size may be too small for region to align to large page size

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/128/head:pull/128
$ git checkout pull/128

Update a local copy of the PR:
$ git checkout pull/128
$ git pull https://git.openjdk.java.net/jdk16u pull/128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 128

View PR using the GUI difftool:
$ git pr show -t 128

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/128.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5ad4a91c3d89f7118a99e5bd56fc86a9a6d57abf 8268127: Shenandoah: Heap size may be too small for region to align to large page size Jun 11, 2021
@openjdk
Copy link

openjdk bot commented Jun 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 11, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268127: Shenandoah: Heap size may be too small for region to align to large page size

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants