This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
8268127: Shenandoah: Heap size may be too small for region to align to large page size #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to backport this Shenandoah specific patch to 16u, which allows to fallback to regular pages for regions, if heap size is too small to allow regions to use large pages.
The original patch does not apply cleanly, resolved then manually.
Test:
Manually test to ensure large pages are used. Failed w/o the patch and passed with it.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/128/head:pull/128
$ git checkout pull/128
Update a local copy of the PR:
$ git checkout pull/128
$ git pull https://git.openjdk.java.net/jdk16u pull/128/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 128
View PR using the GUI difftool:
$ git pr show -t 128
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/128.diff