Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sidecarSet control to openkruise/utils repo #1152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Dec 27, 2022

Signed-off-by: liheng.zms [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@pigletfly
Copy link
Contributor

Is sidecarSet control used in other repos?

@kruise-bot
Copy link

@zmberg: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmberg zmberg modified the milestones: v1.5, 1.6, 1.7 Mar 7, 2024
@zmberg zmberg modified the milestones: 1.7, 1.8 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants