Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A feature-gate to limit CloneSet pod name within 63 chars or less #1737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veophi
Copy link
Member

@veophi veophi commented Sep 11, 2024

Ⅰ. Describe what this PR does

follow the name generation of Deployment https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/names/generate.go#L53.

Ⅱ. Does this pull request fix one issue?

#1736

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.18%. Comparing base (0d0031a) to head (e9aeb7e).
Report is 122 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/cloneset/core/cloneset_core.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
+ Coverage   47.91%   49.18%   +1.26%     
==========================================
  Files         162      191      +29     
  Lines       23491    19576    -3915     
==========================================
- Hits        11256     9628    -1628     
+ Misses      11014     8695    -2319     
- Partials     1221     1253      +32     
Flag Coverage Δ
unittests 49.18% <85.71%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kruise-bot
Copy link

@veophi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants