Card year expiry date must be saved as Char on the database #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The field is Int on forms and wizards, but stored as char on the database. Let me know if you prefer to store as int on the database. |
|
The preference would be to store as Char because that is what most APIs seem to expect. |
|
So this is the correct way to manage it. The build Failed, but AFAIU is not caused by my patch. |
| @@ -721,7 +721,7 @@ def complete_using_credit_card(cls, credit_card_form): | |||
| profile_wiz.card_info.expiry_month = \ | |||
| credit_card_form.expiry_month.data | |||
| profile_wiz.card_info.expiry_year = \ | |||
| credit_card_form.expiry_year.data | |||
| str(credit_card_form.expiry_year.data) | |||
There was a problem hiding this comment.
why not make the expiry_year field itself char ?
There was a problem hiding this comment.
Because the validator in the form requires it to be int in order to check correctly that year is in the selection.
Neverdeles, we can cast the selection values to string on the validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.