Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layer / schema Documentation #368

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Falke-Design
Copy link
Contributor

This should explain and help beginners (like I'm) to understand how own layers can be created.

There are many TODOs and I can't solve them all, because I don't understand how some parts are working and what happing there. It would be very nice if you can help!

Openmaptiles Doc PR: openmaptiles/openmaptiles#1219
Openmaptiles Issue: openmaptiles/openmaptiles#1211



Take a look or copy a standard layer like [building](https://github.com/openmaptiles/openmaptiles/tree/master/layers/building) to get started with your own layer.
A layer consists out of a **Layer** definition written in YAML format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: remove word "out"

```
make start-tileserver
```
And go to `localhost:8090`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my system, this comes up as :8080, not sure where the 8090 comes from.

| etl_diagram.png | TODO: EXPLAIN ME |
| mapping_diagram.png | TODO: EXPLAIN ME |
| update_park_polygon.sql | TODO: EXPLAIN ME |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we explaining how to create a layer for inclusion in OpenMapTiles, or how to create a custom layer that you aren't contributing? If it's going in the repository, ETL diagrams are definitely not optional.

| park.yaml | Start point / General definition file. Contains `description`, `fields`, `buffer_size`, `schema`, `datasources`, ... |
| mapping.yaml | [Imposm3 mapping file](https://imposm.org/docs/imposm3/latest/mapping.html). Definition how and where the OSM Data schould be stored in the Database. |
| park.sql | Creates SQL functions to get the correct data from the database while tile-generation |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A description of the update process is needed here. Otherwise, tables will only get an initial load if any tables are created beyond the ones that imposm makes.

@zstadler
Copy link
Contributor

In some cases, a new map requirement can be addressed by adding a field to an existing layer.
It would be great if this PR can also describe this flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants