Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing all reactions for ENDF 7.1 chain file #84

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jul 5, 2023

as mentioned in issue #83 it is perhaps best to include all the reactions in the chain files

This PR adds a arguments to the processing script when it calls chain.from_endf so that all the reactions are included in the chain file

I am going to implement these changes over on my fork that has evolved into a package 😄 as well but wanted to help keep this repo up to date

@shimwell shimwell changed the title processing all reactions for EDNF 7.1 chain file processing all reactions for ENDF 7.1 chain file Jul 5, 2023
@paulromano
Copy link
Contributor

@shimwell Despite my comments in #83, I don't recommend that we add all reactions right now. Currently, including all reactions is going to result in very high memory usage for depletion calculations because OpenMC will create reaction rate tallies for every reaction present. The first thing we need is a way for the reactions to be configured when running a depletion calculation (i.e., one can specify a subset of the reactions to be included).

@shimwell
Copy link
Member Author

shimwell commented Jul 5, 2023

Yes that makes sense, I guess we come back to this PR in the future.

In the meantime I'm going to run a few of depletion simulations and see how much RAM is needed for my own specific cases.

In one case I just have an Al27 vessel as the only depletable material. So that might not need too much RAM. I see that Al reactions go from 4 to 15 so it should give me a better answer.

  <nuclide name="Al27" reactions="4">
    <reaction type="(n,2n)" Q="-13058200.0" target="Al26"/>
    <reaction type="(n,gamma)" Q="7725200.0" target="Al28"/>
    <reaction type="(n,p)" Q="-1828549.0" target="Mg27"/>
    <reaction type="(n,a)" Q="-3130330.0" target="Na24"/>
  </nuclide>

to

  <nuclide name="Al27" reactions="15">
    <reaction type="(n,2n)" Q="-13058200.0" target="Al26"/>
    <reaction type="(n,na)" Q="-10089800.0" target="Na23"/>
    <reaction type="(n,np)" Q="-8272130.0" target="Mg26"/>
    <reaction type="(n,nd)" Q="-17140200.0" target="Mg25"/>
    <reaction type="(n,nt)" Q="-18213600.0" target="Mg24"/>
    <reaction type="(n,npa)" Q="-18883900.0" target="Ne22"/>
    <reaction type="(n,gamma)" Q="7725200.0" target="Al28"/>
    <reaction type="(n,p)" Q="-1828549.0" target="Mg27"/>
    <reaction type="(n,d)" Q="-6047544.0" target="Mg26"/>
    <reaction type="(n,t)" Q="-10882930.0" target="Mg25"/>
    <reaction type="(n,a)" Q="-3130330.0" target="Na24"/>
    <reaction type="(n,2a)" Q="-13958300.0" target="F20"/>
    <reaction type="(n,2p)" Q="-16799900.0" target="Na26"/>
    <reaction type="(n,pa)" Q="-13683800.0" target="Ne23"/>
    <reaction type="(n,da)" Q="-16659400.0" target="Ne22"/>
  </nuclide>

@shimwell shimwell marked this pull request as draft July 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants