Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pincell Maker #2608

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Pincell Maker #2608

wants to merge 30 commits into from

Commits on Jun 19, 2023

  1. added a method pin_both that divides a pincell both radially and azim… 

    …uthally
    @sreegudala
    sreegudala committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    64027da View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. removed pin_azimuthal function which is now just a part of pin_both f… 

    …unction
    @sreegudala
    sreegudala committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    83e2957 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. added tests to test_pin to test pin_new function

    @sreegudala
    sreegudala committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b2e9dd9 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. removed divide_vols parameter from pincell method

    @sreegudala
    sreegudala committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c7da4c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. added a zero subdivision error catch, created regression test for pin… 

    …_new method
    @sreegudala
    sreegudala committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a500d31 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. starting angle for azimuthal subdivisions changed to pi/4

    @sreegudala
    sreegudala committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    653335c View commit details
    Browse the repository at this point in the history

  2. update

    @sreegudala
    sreegudala committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    086f128 View commit details
    Browse the repository at this point in the history

  3. Created new CylinderSectorUpdated class to handle sectors with zero i… 

    …nner radius
    @sreegudala
    sreegudala committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6f83b18 View commit details
    Browse the repository at this point in the history

  4. added documentation for CylinderrSectorUpdated class

    @sreegudala
    sreegudala committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    79dd9ad View commit details
    Browse the repository at this point in the history

  5. added regression test for pin_radial_azimuthal function

    @sreegudala
    sreegudala committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    bef11bb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. made CylinderSectorUpdated class a child class of CylinderSector

    @sreegudala
    sreegudala committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f05163f View commit details
    Browse the repository at this point in the history

  2. extended CylinderSector class to handle case of zero radius cylinders

    @sreegudala
    sreegudala committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    417e7c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. CylinderSector now reuses planes so there are not any extra surfaces

    @sreegudala
    sreegudala committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d73c22a View commit details
    Browse the repository at this point in the history

  2. Made rad_div_types into a dictionary to allow each radial division to… 

    … have a different division type
    @sreegudala
    sreegudala committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5aa97b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Changed the rad_div_types to not require a division type for every ring

    @sreegudala
    sreegudala committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a3cc573 View commit details
    Browse the repository at this point in the history

  2. added implicit_azi_div variable

    @sreegudala
    sreegudala committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e26073b View commit details
    Browse the repository at this point in the history

  3. added implicit_azi_div variable to pin_radial_azimuthal function

    @sreegudala
    sreegudala committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ad11cf8 View commit details
    Browse the repository at this point in the history

  4. changed CylinderSector to handle case of r2 = None, i.e. when r2 exte… 

    …nds to infinity
    @sreegudala
    sreegudala committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    678a7f5 View commit details
    Browse the repository at this point in the history

  5. added documentation for pin_radial_azimuthal function

    @sreegudala
    sreegudala committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    729c9ac View commit details
    Browse the repository at this point in the history

  6. changed documentation for pin_radial_azimuthal function

    @sreegudala
    sreegudala committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    b046468 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. regression test for pin_radial_azimuthal

    @sreegudala
    sreegudala committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6a6e68f View commit details
    Browse the repository at this point in the history

  2. regression test for pin_radial_azimuthal

    @sreegudala
    sreegudala committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b505867 View commit details
    Browse the repository at this point in the history

  3. regression test for pin_radial_azimuthal

    @sreegudala
    sreegudala committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8ececc1 View commit details
    Browse the repository at this point in the history

  4. updated parameters for pin_radial_azimuthal

    @sreegudala
    sreegudala committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    10a7537 View commit details
    Browse the repository at this point in the history

  5. added documentation for pin_radial_azimuthal

    @sreegudala
    sreegudala committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    33e7f9f View commit details
    Browse the repository at this point in the history

  6. CylinderSector can handle case of r1=0 and r2=None, also added docume… 

    …ntation
    @sreegudala
    sreegudala committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    be1cf36 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. reverted changes to build_xml

    @sreegudala
    sreegudala committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    62d34fc View commit details
    Browse the repository at this point in the history

  2. added pin_radial_azimuthal function to model

    @sreegudala
    sreegudala committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4050480 View commit details
    Browse the repository at this point in the history

  3. reverted changes to build_xml

    @sreegudala
    sreegudala committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    01523f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. adding init.py file to run test

    @sreegudala
    sreegudala committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7f11d3e View commit details
    Browse the repository at this point in the history