added universe plot tests to catch color=None and axis values #2637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While plotting some geometry I kept getting an empty legend, I had set
legend=True
so I wasn't sure why it was blank 😕Looking through the universe.plot source code I noticed that when setting legend to True we also have to set the
colours
. However the check for colors was not actually being triggered asplot.colors
defaults to{}
This PR fixes the logic so that passing in legend=True without setting colors now triggers a ValueError if colors is not set as well as originally intended.
I've added a test to safe guard this feature and while in the universe plot unit test I also added some asserts to check the axis labels are as expected ✔️
Fixes # (issue)
Checklist
- [x] I have run clang-format on any C++ source files (if applicable)- [x] I have made corresponding changes to the documentation (if applicable)