Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Universe.plot seed. #2647

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Fixing Universe.plot seed. #2647

merged 3 commits into from
Aug 19, 2023

Conversation

pshriwise
Copy link
Contributor

@pshriwise pshriwise commented Aug 13, 2023 •
edited
Loading

Description

Adds an openmc.Settings.plot_seed attribute on the Python side and ingests it during a load of settings.xml to set the model::plotter_seed value.

Screenshot 2023-08-13 at 3 07 05 PM

Fixes #2646

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

gridley
gridley approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@gridley gridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paulromano
paulromano approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulromano paulromano enabled auto-merge (squash) August 18, 2023 22:19
@paulromano paulromano merged commit fa245b0 into openmc-dev:develop Aug 19, 2023
16 checks passed
stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
@pshriwise @paulromano @stchaker
Fixing Universe.plot seed. (openmc-dev#2647)
a638d95 
Co-authored-by: Paul Romano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridley gridley gridley approved these changes

@paulromano paulromano paulromano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Universe.plot seed does not change color behavior.
3 participants
@pshriwise @paulromano @gridley