Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing other dose coefficients and adding ICRP119 neutron #2749

Closed

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Oct 26, 2023

Description

This PR allows us to add additional dose conversion libraries. We can add others in the future but for now I've included ICRP119 neutron data which is on page 123 of this report

The ICRP 119 compared to the ICRP 116 is a slightly different, here is a plot for your interest

icrp_200

tagging @rlbarker for your interest

Fixes # (issue)
#2516

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)

relying on existing tests in tests/unit_tests/data_dose_coefficients.py

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimwell Sorry it took me so long to get you a review on this one. I'm trying to understand the purpose of ICRP 119. It looks like that report is really just a compilation of data from older reports (specifically ICRP 60, which is from 1990). Would it not be better to have ICRP 60 directly be the data source? Furthermore, I've never seen any papers with people using ICRP 60 for evaluating dose -- can you point me to a work where either 60 or 119 was used? Sorry if these are dumb questions as I'm not a health physicist 😄

openmc/data/effective_dose/dose.py Outdated Show resolved Hide resolved
@shimwell
Copy link
Member Author

ICRP119 was my go to dose coefficient to try adding as it comes from the same places as the other one we already have so I thought it would be a simple update. I see what you are saying about it actually being ICRP60 so perhaps this is not the best one to add

I'm actually more interested in adding the same dose coefficients as FLUKA uses which would make comparing the codes easier. Could I add these photon coefficients instead?

@shimwell
Copy link
Member Author

shimwell commented Oct 7, 2024

Closing as #3020 has implemented this idea with another library

@shimwell shimwell closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants