-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External transfer rates source term #3088
Open
church89
wants to merge
88
commits into
openmc-dev:develop
Choose a base branch
from
openmsr:transfer_rates_source_term
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aming according to new transfer rates class
…and external source rate time dependency feature
…nal source rate term to bateman matrix; make both transfer rate and external source rate time dependent
…a constant (time-depenedent) source term; make ExternalSourceRate and TransferRate derived classes from new ExternalRate one
Merge Transfer rates source term into openmsr develop branch
add forgotten imports
Fix ext source rate timesteps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up of the recent TransfeRates, adding a further external source term$S$ to the depletion solver:
The linear system can be easily homogenized adding the source vector to the Bateman matrix and a dummy nuclide vector as such:
For reference see: Isotalo et al
This allows to input feed or removal fixed source rate during a depletion run, similar to the ORIGEN module of SCALE.
To set an external source rate, similar to a transfer rate, one can simply add to an integrator instance, as such:
with default units:$grams/sec$
In the same PR I've also included a time-dependency, both to this and TransferRates, allowing to specify specific depletion time-steps where to activate these modeling, adding a timesteps argument to the setter functions.
Verification
As a simple verification I've compared with a depletion case, where I manually modify the material composition between two depletion steps:
Checklist