Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #3158 - Streamline use of CompositeSurface with SurfaceFilter #3167

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Fix for issue #3158 - Streamline use of CompositeSurface with SurfaceFilter #3167

wants to merge 11 commits into from

Commits on Oct 11, 2024

  1. CompositeSurface get_surface() and get_id_surface() added

    @zoeprieto
    zoeprieto committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f07974e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Update openmc/model/surface_composite.py 

    Co-authored-by: Patrick Shriwise <[email protected]>
    @zoeprieto @pshriwise
    zoeprieto and pshriwise authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e4c0ee8 View commit details
    Browse the repository at this point in the history

  2. Update openmc/model/surface_composite.py 

    Co-authored-by: Patrick Shriwise <[email protected]>
    @zoeprieto @pshriwise
    zoeprieto and pshriwise authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c418c32 View commit details
    Browse the repository at this point in the history

  3. SurfaceFilter accept CompositeSurface

    @zoeprieto
    zoeprieto committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9f03bcc View commit details
    Browse the repository at this point in the history

  4. SurfaceFilter fix

    @zoeprieto
    zoeprieto committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f0cee3a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. CompositeSource + Surfaces and warning added

    @zoeprieto
    zoeprieto committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a7fa568 View commit details
    Browse the repository at this point in the history

  2. fix when there is only CompositeSurface

    @zoeprieto
    zoeprieto committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7c8df81 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Refactor addition of component surfaces to SurfaceFilter

    @pshriwise
    pshriwise committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    906763d View commit details
    Browse the repository at this point in the history

  2. Refactor bin checking/cleaning for WithIDFilter

    @pshriwise
    pshriwise committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7d2e116 View commit details
    Browse the repository at this point in the history

  3. Updating surface filter test w/ composite surfaces

    @pshriwise
    pshriwise committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    066f2a4 View commit details
    Browse the repository at this point in the history

  4. Handle single objects up front in SurfaceFilter.clean_bins

    @pshriwise
    pshriwise committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f37d7d9 View commit details
    Browse the repository at this point in the history