Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a vessel composite surface with ellipsoids on top and bottom. #3168

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Add a vessel composite surface with ellipsoids on top and bottom. #3168

merged 7 commits into from
Nov 12, 2024

Commits on Oct 13, 2024

  1. Add a composite surface called vessel, which includes a 'ZCylinder' w… 

    …ith ellipsoids on top and bottom.
    @nsedayilmaz
    nsedayilmaz authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5aab24c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Update openmc/model/surface_composite.py 

    Co-authored-by: Patrick Shriwise <[email protected]>
    @nsedayilmaz @pshriwise
    nsedayilmaz and pshriwise authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    365fae6 View commit details
    Browse the repository at this point in the history

  2. Update openmc/model/surface_composite.py 

    Co-authored-by: Patrick Shriwise <[email protected]>
    @nsedayilmaz @pshriwise
    nsedayilmaz and pshriwise authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4ad38ff View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Update test_surface_composite.py 

    Add a test for ZVessel composite surface
    @nsedayilmaz
    nsedayilmaz authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b6e6e36 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Generalize vessel to x, y, or z axis

    @paulromano
    paulromano committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    064e182 View commit details
    Browse the repository at this point in the history

  2. Update argment names, add tests for Vessel

    @paulromano
    paulromano committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    28139dd View commit details
    Browse the repository at this point in the history

  3. Add missing type hint

    @paulromano
    paulromano committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    79dd442 View commit details
    Browse the repository at this point in the history