Immediate updates to score selection for tally plotting #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thanks @paulromano! I agree that this cleans up the logic around scores considerably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when you are plotting tallies, if your tally has multiple scores and you want to select a different one, you have to deselect the currently selected one, hit apply, and then select a new one. The changes in this PR make it so that when you deselect a score, it immediately updates which checkboxes are active so that you don't have to hit apply in between. I also changed some of the special logic around the 'total' score which, in my opinion, just complicated things more.