Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make items in filter list auto tristate #150

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

paulromano
Copy link
Contributor

If you have a mesh tally with other filters on top, right now it's not possible to pick out specific bins from those other filters. After digging into this a while, I realized that the problem was that the top-level treewidget items were not being set to "auto tristate", which allows them to be partially checked based on the state of the child items. With this change, now you can select bins for these filters freely. In my particular use case, I'm combining a material filter with a mesh filter and want to plot the mesh results restricted to a particular material.

@paulromano paulromano requested a review from pshriwise June 6, 2024 19:34
@shimwell
Copy link
Member

shimwell commented Jun 6, 2024

Oh this looks handy for shut down dose rate analysis, thanks Paul

@paulromano
Copy link
Contributor Author

Just added one more fix for the cell/material highlight checkboxes in the color options dialog not working.

@paulromano paulromano linked an issue Jun 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @paulromano!

@pshriwise
Copy link
Collaborator

Just added one more fix for the cell/material highlight checkboxes in the color option

I noticed that too yesterday. Thanks!

@pshriwise pshriwise merged commit d7ac96a into openmc-dev:develop Jun 7, 2024
1 check passed
@paulromano paulromano deleted the filter-tristate branch June 7, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Mask" and "Highlight" Checkbox Not Functional in PySide6 Migration
3 participants