feat: use duration for plan phases instead of start after

openmeterio · Dec 10, 2024 · 4a1a066 · 4a1a066
1 parent f585e01
commit 4a1a066
Show file tree

Hide file tree

Showing 17 changed files with 1,137 additions and 887 deletions.
diff --git a/api/api.gen.go b/api/api.gen.go
diff --git a/api/openapi.yaml b/api/openapi.yaml
@@ -13122,7 +13122,7 @@ components:
         - key
         - name
         - rateCards
-        - startAfter
+        - duration
       properties:
         key:
           type: string
@@ -13155,13 +13155,13 @@ components:
             $ref: '#/components/schemas/RateCard'
           description: The rate cards of the plan.
           title: Rate cards
-        startAfter:
+        duration:
           type: string
           format: duration
           nullable: true
           example: P1Y1D
-          description: The time after which the plan starts compared to subscription start
-          title: Start after
+          description: The duration of the phase.
+          title: Duration
         discounts:
           type: array
           items:
@@ -13175,7 +13175,7 @@ components:
         - key
         - name
         - rateCards
-        - startAfter
+        - duration
       properties:
         key:
           type: string
@@ -13208,13 +13208,13 @@ components:
             $ref: '#/components/schemas/RateCard'
           description: The rate cards of the plan.
           title: Rate cards
-        startAfter:
+        duration:
           type: string
           format: duration
           nullable: true
           example: P1Y1D
-          description: The time after which the plan starts compared to subscription start
-          title: Start after
+          description: The duration of the phase.
+          title: Duration
         discounts:
           type: array
           items:
@@ -13275,13 +13275,13 @@ components:
             $ref: '#/components/schemas/RateCard'
           description: The rate cards of the plan.
           title: Rate cards
-        startAfter:
+        duration:
           type: string
           format: duration
           nullable: true
           example: P1Y1D
-          description: The time after which the plan starts compared to subscription start
-          title: Start after
+          description: The duration of the phase.
+          title: Duration
         discounts:
           type: array
           items:

diff --git a/api/spec/src/productcatalog/plan.tsp b/api/spec/src/productcatalog/plan.tsp
@@ -154,13 +154,13 @@ model PlanPhase {
   rateCards: RateCard[];
 
   /**
-   * The time after which the plan starts compared to subscription start
+   * The duration of the phase.
    */
   @visibility("read", "create", "update")
-  @summary("Start after")
+  @summary("Duration")
   @encode(DurationKnownEncoding.ISO8601)
   @example(duration.fromISO("P1Y1D"))
-  startAfter: duration | null;
+  duration: duration | null;
 
   /**
    * The discounts on the plan.

diff --git a/openmeter/ent/db/migrate/schema.go b/openmeter/ent/db/migrate/schema.go
diff --git a/openmeter/ent/db/mutation.go b/openmeter/ent/db/mutation.go